#19 makefile fails to fail

closed-fixed
None
3
2011-01-31
2010-03-27
No

The main makefile calls $(MAKE) inside a subdirectory but discards the return status of that invocation. If "&&" is used in place of ";", the main makefile will properly fail if the invocation of make inside the source directory fails (as is currently the case if only libpng 1.4 is installed). I'm attaching a patch that works for me (although you'll probably want to fix this in other places as well).

Discussion

  • Cosmin Truta

    Cosmin Truta - 2010-03-30

    Good catch, Elias, and thank you :-)
    I will apply this modification in the next release.

    Best regards,
    Cosmin

     
  • Cosmin Truta

    Cosmin Truta - 2010-03-30
    • priority: 5 --> 3
    • assigned_to: nobody --> cosmin
    • status: open --> open-accepted
     
  • Cosmin Truta

    Cosmin Truta - 2011-01-31
    • status: open-accepted --> closed-fixed
     
  • Cosmin Truta

    Cosmin Truta - 2011-01-31

    Fixed in v0.6.5.

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks