Menu

#15 crash with particular GIF

closed-fixed
None
7
2009-05-20
2009-02-09
Roy Tam
No

I'm getting 'The instruction at "0x77c11165" referenced memory at "0x005b8000". the memory could not be "written".' error with this GIF.

Discussion

  • Cosmin Truta

    Cosmin Truta - 2009-02-13
    • assigned_to: nobody --> cosmin
     
  • Cosmin Truta

    Cosmin Truta - 2009-02-13

    Hello, Roy,
    Thank you very much for your report. I confirm the problem that you reported, and I will provide a fix.
    I am deleting the attached file for the time being, and I will put it back after the fix is released.

    Best regards,
    Cosmin

     
  • Nobody/Anonymous

    The crash is in GIFReadNextExtension. There is a realloc() call that might return new memory, and a ptr variable that caches the old value of the memory and continutes to write to it. The fix is to do something like:

    222c222
    < size_t offset;
    ---
    > unsigned char *ptr;
    236c236
    < offset = 0;
    ---
    > ptr = ext->Buffer;
    246c246
    < count = ReadDataBlock(ext->Buffer + offset, stream);
    ---
    > count = ReadDataBlock(ptr, stream);
    249c249
    < offset += count;
    ---
    > ptr += count;

     
  • Nobody/Anonymous

    oops, the diffs are reversed; swap < for >, and > for <.

     
  • Cosmin Truta

    Cosmin Truta - 2009-02-25

    Roy,

    I issued a suite of security patches, available from the OptiPNG home page.
    The fix will be incorporated in the next release.

    Both your report and your fix are highly appreciated.
    Thank you very much!

     
  • Cosmin Truta

    Cosmin Truta - 2009-02-25
    • priority: 5 --> 7
    • status: open --> open-accepted
     
  • Cosmin Truta

    Cosmin Truta - 2009-05-20

    The previously-removed file is put back

     
  • Cosmin Truta

    Cosmin Truta - 2009-05-20

    Closing this defect, at last.
    Many thanks to Roy for reporting, and to Bryan McQuade for the fix.

     
  • Cosmin Truta

    Cosmin Truta - 2009-05-20
    • status: open-accepted --> closed-fixed
     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.