Help save net neutrality! Learn more.
Close

Commit [f76a07]  Maximize  Restore  History

Fix two makefiles to use -Werror, and fix resulting compiler errors

I discovered that the Makefile.am files in libperf_events and
libpe_utils did not set AM_CXXFLAGS = @OP_CXXFLAGS@, and thus,
the extra -W flags that are added to OP_CXXFLAGS (in configure.ac)
were not being used when building these two directories. Once
I corrected this problem with the makefiles and rebuilt the
source tree, the g++ compiler found a number of minor issues
and ended in error due to the -Werror flag. This patch contains
fixes for the two Makefile.am files, as well as fixes for the
compiler's warnings-turned-to-errors. These were all minor issues
that I'm fairly confident should not have caused any functional
problems. Both manual testing and oprofile testsuite pass
with this patch applied.

Signed-off-by: Maynard Johnson <maynardj@us.ibm.com>

Maynard Johnson Maynard Johnson 2013-12-19

changed libpe_utils/Makefile.am
changed libperf_events/Makefile.am
changed libperf_events/operf_counter.cpp
changed libperf_events/operf_process_info.cpp
changed libperf_events/operf_utils.cpp
libpe_utils/Makefile.am Diff Switch to side-by-side view
Loading...
libperf_events/Makefile.am Diff Switch to side-by-side view
Loading...
libperf_events/operf_counter.cpp Diff Switch to side-by-side view
Loading...
libperf_events/operf_process_info.cpp Diff Switch to side-by-side view
Loading...
libperf_events/operf_utils.cpp Diff Switch to side-by-side view
Loading...