Help save net neutrality! Learn more.
Close

Commit [8a2ede]  Maximize  Restore  History

Fix cryptic objdump error message from opannotate for /proc/kallsyms

Since the pseudo file /proc/kallsyms does not physically exist, the
objdump command done on it (when running 'opannotate --assembly')
returns nothing to stdout. Eventually, the code in opannotate.cpp's
do_one_output_objdump function checks the state of reader.error after
termination of the objdump reader process; it finds some problem
there and prints the message "objdump returned 1". Under certain
conditions, an 'opannotate -a' run can result in several dozen of
these annoying messages. This patch fixes the issue by simply
ignoring /proc/kallsyms and not even trying to do objdump on it.

Signed-off-by: Maynard Johnson <maynardj@us.ibm.com>

Maynard Johnson Maynard Johnson 2014-08-26

changed pp/opannotate.cpp
pp/opannotate.cpp Diff Switch to side-by-side view
Loading...