From: Gisle D. <gi...@tr...> - 2008-04-16 20:16:50
Attachments:
opd_anon.patch
|
As discussed, here's a very simple patch that solves my problem and hopefully will work for everyone else too. Cheers, Gisle -- Gisle Dankel Principal Engineer Transitive Maybrook House, 40 Blackfriars Street, Manchester M3 2EG Phone: +44 (0)161 836 2343 Fax: +44 (0)161 836 2399 www.transitive.com * Eliminate the hardware|software dependency This E-mail and any attachments hereto are strictly confidential and intended solely for the addressee. If you are not the intended addressee please notify the sender by return and delete the message. You must not disclose, forward or copy this E-mail or attachments to any third party without the prior consent of the sender. |
From: John L. <le...@mo...> - 2008-04-16 21:33:02
|
On Wed, Apr 16, 2008 at 09:16:42PM +0100, Gisle Dankel wrote: > As discussed, here's a very simple patch that solves my problem and > hopefully will work for everyone else too. There's a comment above that you'd need to fix. I'd prefer it if that comment were in just one place, and it described the reasoning behind what we do and don't track. I see the code mentions that we look for '[heap]'. I suppose there's a reason for that. regards john |
From: Gisle D. <gi...@tr...> - 2008-04-16 22:26:48
|
John Levon wrote: > On Wed, Apr 16, 2008 at 09:16:42PM +0100, Gisle Dankel wrote: > > >> As discussed, here's a very simple patch that solves my problem and >> hopefully will work for everyone else too. >> > > There's a comment above that you'd need to fix. I'd prefer it if that > comment were in just one place, and it described the reasoning behind > what we do and don't track. > > I see the code mentions that we look for '[heap]'. I suppose there's a > reason for that. > Ah yes, will create a combined comment. If someone could shed some light on what [heap] is used for, it'd be interesting. Should I perhaps add the other types as examples in the comment as well? Cheers, Gisle -- Gisle Dankel Principal Engineer Transitive Maybrook House, 40 Blackfriars Street, Manchester M3 2EG Phone: +44 (0)161 836 2343 Fax: +44 (0)161 836 2399 www.transitive.com * Eliminate the hardware|software dependency This E-mail and any attachments hereto are strictly confidential and intended solely for the addressee. If you are not the intended addressee please notify the sender by return and delete the message. You must not disclose, forward or copy this E-mail or attachments to any third party without the prior consent of the sender. |
From: Gisle D. <gi...@tr...> - 2008-04-17 20:39:21
Attachments:
opd_anon.patch
|
Updated patch with the comments change. Gisle John Levon wrote: > On Wed, Apr 16, 2008 at 09:16:42PM +0100, Gisle Dankel wrote: > > >> As discussed, here's a very simple patch that solves my problem and >> hopefully will work for everyone else too. >> > > There's a comment above that you'd need to fix. I'd prefer it if that > comment were in just one place, and it described the reasoning behind > what we do and don't track. > > I see the code mentions that we look for '[heap]'. I suppose there's a > reason for that. > > regards > john > -- Gisle Dankel Principal Engineer Transitive Maybrook House, 40 Blackfriars Street, Manchester M3 2EG Phone: +44 (0)161 836 2343 Fax: +44 (0)161 836 2399 www.transitive.com * Eliminate the hardware|software dependency This E-mail and any attachments hereto are strictly confidential and intended solely for the addressee. If you are not the intended addressee please notify the sender by return and delete the message. You must not disclose, forward or copy this E-mail or attachments to any third party without the prior consent of the sender. |