From: John L. <le...@mo...> - 2003-02-09 03:02:19
|
--ctr0-unit-mask=0x01 fails --ctr0-unit-mask=0x1 fails --ctr0-unit-mask=1 succeeds What's going on ? john |
From: William C. <wc...@nc...> - 2003-02-09 17:06:59
|
I have seen this problem on some machines. However, I can't seem to reproduce on my home machines. Could you put a "#!/bin/bash -x" at the beginning of opcontrol to find out where it is complaining about it. Anymore details? -Will John Levon wrote: > --ctr0-unit-mask=0x01 fails > --ctr0-unit-mask=0x1 fails > --ctr0-unit-mask=1 succeeds > > What's going on ? > > john > > > > ------------------------------------------------------- > This SF.NET email is sponsored by: > SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See! > http://www.vasoftware.com > _______________________________________________ > oprofile-list mailing list > opr...@li... > https://lists.sourceforge.net/lists/listinfo/oprofile-list > |
From: John L. <le...@mo...> - 2003-02-09 17:30:04
|
On Sun, Feb 09, 2003 at 12:06:47PM -0500, William Cohen wrote: > I have seen this problem on some machines. However, I can't seem to > reproduce on my home machines. Could you put a "#!/bin/bash -x" at the > beginning of opcontrol to find out where it is complaining about it. > Anymore details? This was on Andrew Morton's P4 box in 2.5. I haven't tried it myself yet. john |
From: William C. <wc...@nc...> - 2003-02-09 21:14:41
|
I think that the variables are getting set to be strings, e.g. "0x01", and the echo in is writing the string out to the device file in do_sysctl_setup_25(). opcontrol probably should convert the value to a decimal value before the variables are saved in ~root/.oprofile/daemonrc. -Will John Levon wrote: > --ctr0-unit-mask=0x01 fails > --ctr0-unit-mask=0x1 fails > --ctr0-unit-mask=1 succeeds > > What's going on ? > > john > > > > ------------------------------------------------------- > This SF.NET email is sponsored by: > SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See! > http://www.vasoftware.com > _______________________________________________ > oprofile-list mailing list > opr...@li... > https://lists.sourceforge.net/lists/listinfo/oprofile-list > |
From: Philippe E. <ph...@wa...> - 2003-02-09 23:15:30
|
William Cohen wrote: > I think that the variables are getting set to be strings, e.g. "0x01", > and the echo in is writing the string out to the device file in > do_sysctl_setup_25(). opcontrol probably should convert the value to a > decimal value before the variables are saved in ~root/.oprofile/daemonrc. > > -Will > > John Levon wrote: > >> --ctr0-unit-mask=0x01 fails >> --ctr0-unit-mask=0x1 fails >> --ctr0-unit-mask=1 succeeds >> >> What's going on ? at my point of view the problem is in 2.5 module: oprofilefs.c:oprofilefs_ulong_from_user() .... - *val = simple_strtoul(tmpbuf, NULL, 10); + *val = simple_strtoul(tmpbuf, NULL, 0); 2.4 module call proc_dointvec which allow octal/hexa/decimal. We need perhaps also to validate the result regards, Phil |
From: John L. <le...@mo...> - 2003-02-09 23:44:12
|
On Mon, Feb 10, 2003 at 12:17:00AM +0000, Philippe Elie wrote: > - > *val = simple_strtoul(tmpbuf, NULL, 10); > + > *val = simple_strtoul(tmpbuf, NULL, 0); Yes, how obvious. I'll wrap this in for Linus in a bit. thanks john |