From: Robert R. <rob...@am...> - 2008-12-02 18:17:03
|
William, before commit 4b9f12a3 that changes cpu detection for kernel 2.6.27, model 13 returned "i386/piii" (maybe I am wrong reading the code). However, the spec says "i386/p6_mobile" and I think this change is fine, though I could not test it. Could you reply with your Signed-off-by please. Andi, could you ack this patch please, it seems to be ok. -Robert On 02.12.08 10:02:32, William Cohen wrote: > The are some corrections in the oprofile i386 identification code to > properly identify some versions of pentium iii and p6_mobile. The patch > resolved problem on celeron based eeepc. The corrections were based on data > on in the Intel AP-485. Would it be possible to get this into the upstream > kernel? > > -Will > Subject: Re: latest oprofile release fails on linux >2.6.26 (i386/p6) > Date: Sun, 30 Nov 2008 15:39:10 -0500 > From: William Cohen <wc...@re...> > To: Alan Jenkins <ala...@tu...> > Cc: opr...@li... > > Alan Jenkins wrote: >> This is on an EeePC 701, /proc/cpuinfo as attached. >> Is this expected? Will the next release work? >> Thanks, Alan >> # opcontrol --setup --no-vmlinux >> cpu_type 'unset' is not valid >> you should upgrade oprofile or force the use of timer mode >> # opcontrol -v >> opcontrol: oprofile 0.9.4 compiled on Nov 29 2008 22:44:10 >> # cat /dev/oprofile/cpu_type >> i386/p6 >> # uname -r >> 2.6.28-rc6eeepc > > Hi Alan, > > Looking at the kernel driver code for oprofile it can return the "i386/p6" > for the cpu_type. However, looking at the user-space oprofile code there > isn't the matching entry in libop/op_cpu_type.c or the events/unit_mask > files in events/i386 directory. > > The Intel AP-485 says this is a "Intel Pentium M processor model D". Seems > like the oprofile kernel driver should be identifying the processor as > "i386/p6_mobile" > > The driver identification code doesn't look quite right in nmi_init.c > > http://git.kernel.org/?p=linux/kernel/git/sfr/linux-next.git;a=blob;f=arch/x86/oprofile/nmi_int.c;h=022cd41ea9b4106e5884277096e80e9088a7c7a9;hb=HEAD > > has: > > 409 case 10 ... 13: > 410 *cpu_type = "i386/p6"; > 411 break; > > Referring to the Intel AP-485: > case 10 and 11 should produce "i386/piii" > case 13 should produce "i386/p6_mobile" > > I didn't see anything for case 12. > > Something like the attached patch. I don't have a celeron machine to verify > that changes in this area of the kernel fix thing. > > -Will > > diff --git a/arch/x86/oprofile/nmi_int.c b/arch/x86/oprofile/nmi_int.c > index 584a9ef..9139637 100644 > --- a/arch/x86/oprofile/nmi_int.c > +++ b/arch/x86/oprofile/nmi_int.c > @@ -409,14 +409,13 @@ static int __init ppro_init(char **cpu_type) > *cpu_type = "i386/pii"; > break; > case 6 ... 8: > + case 10 ... 11: > *cpu_type = "i386/piii"; > break; > case 9: > + case 13: > *cpu_type = "i386/p6_mobile"; > break; > - case 10 ... 13: > - *cpu_type = "i386/p6"; > - break; > case 14: > *cpu_type = "i386/core"; > break; > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > oprofile-list mailing list > opr...@li... > https://lists.sourceforge.net/lists/listinfo/oprofile-list -- Advanced Micro Devices, Inc. Operating System Research Center email: rob...@am... |