From: Richard P. <rp...@rp...> - 2007-10-03 15:07:08
|
I have a couple of fixes for oparchive in the patch below: 1. Fix the path to the open_bfd() call for debug symbols by adding a missing prefix (to match the copy call further up). 2. Check list_files option before calling create_dir() for debug files. Cheers, Richard Index: oprofile/pp/oparchive.cpp =================================================================== --- oprofile.orig/pp/oparchive.cpp +++ oprofile/pp/oparchive.cpp @@ -95,7 +95,7 @@ int oparchive(options::spec const & spec * to avoid overwriting files with the same name. The * /usr/lib/debug search path is not going to work. */ - bfd * ibfd = open_bfd(exe_name); + bfd * ibfd = open_bfd(options::archive_path + exe_name); if (ibfd) { string global(options::archive_path + DEBUGDIR); string dirname = op_dirname(options::archive_path + @@ -106,7 +106,7 @@ int oparchive(options::spec const & spec /* found something copy it over */ string dest_debug_dir = options::outdirectory + dirname + "/.debug/"; - if (create_dir(dest_debug_dir.c_str())) { + if (!options::list_files && create_dir(dest_debug_dir.c_str())) { cerr << "Unable to create directory: " << dest_debug_dir << "." << endl; exit (EXIT_FAILURE); Index: oprofile/ChangeLog =================================================================== --- oprofile.orig/ChangeLog +++ oprofile/ChangeLog @@ -1,3 +1,8 @@ +2007-10-03 Richard Purdie <rp...@op...> + + * pp/oparchive.cpp: Fix path to open_bfd() call for debug symbols. + Check list_files option before calling create_dir() for debug files. + 2007-09-28 Richard Purdie <rp...@op...> * events/arm/armv6/events: Fix armv6 events to match mainline kernels |
From: John L. <le...@mo...> - 2007-10-03 16:28:19
|
On Wed, Oct 03, 2007 at 04:06:54PM +0100, Richard Purdie wrote: > 1. Fix the path to the open_bfd() call for debug symbols by adding a > missing prefix (to match the copy call further up). > 2. Check list_files option before calling create_dir() for debug files. Looks fine cheers john |
From: Philippe E. <ph...@wa...> - 2007-11-04 07:25:30
|
On Wed, 03 Oct 2007 at 16:06 +0000, Richard Purdie wrote: > I have a couple of fixes for oparchive in the patch below: > > 1. Fix the path to the open_bfd() call for debug symbols by adding a > missing prefix (to match the copy call further up). > 2. Check list_files option before calling create_dir() for debug files. I did other change in this area, and fixed 1) but missed 2), commited a similar fix for 2) > +++ oprofile/pp/oparchive.cpp ... > @@ -106,7 +106,7 @@ int oparchive(options::spec const & spec > /* found something copy it over */ > string dest_debug_dir = options::outdirectory + > dirname + "/.debug/"; > - if (create_dir(dest_debug_dir.c_str())) { > + if (!options::list_files && create_dir(dest_debug_dir.c_str())) { > cerr << "Unable to create directory: " > << dest_debug_dir << "." << endl; > exit (EXIT_FAILURE); -- Phe |