From: David D. <dd...@av...> - 2005-10-17 21:44:14
|
This patch fixes the lookup_dcookie for the MIPS o32 ABI. Although I only tested with little-endian, the big-endian case needed fixing as well but is untested (but what are the chances that this is not the correct fix?). This is the only patch I needed to get the user space oprofile programs to work for mipsel-linux. I am CCing the linux-mips list as this may be of interest there as well. David Daney. 2005-10-17 David Daney <dd...@av...> * daemon/opd_cookie.c (lookup_dcookie): Handle MIPS o32 for both big and little endian. Index: oprofile/daemon/opd_cookie.c =================================================================== RCS file: /cvsroot/oprofile/oprofile/daemon/opd_cookie.c,v retrieving revision 1.19 diff -p -a -u -r1.19 opd_cookie.c --- oprofile/daemon/opd_cookie.c 26 May 2005 00:00:02 -0000 1.19 +++ oprofile/daemon/opd_cookie.c 17 Oct 2005 21:29:13 -0000 @@ -60,12 +60,21 @@ #endif /* __NR_lookup_dcookie */ #if (defined(__powerpc__) && !defined(__powerpc64__)) || defined(__hppa__)\ - || (defined(__s390__) && !defined(__s390x__)) + || (defined(__s390__) && !defined(__s390x__)) \ + || (defined(__mips__) && (_MIPS_SIM == _MIPS_SIM_ABI32) \ + && defined(_MIPSEB)) static inline int lookup_dcookie(cookie_t cookie, char * buf, size_t size) { return syscall(__NR_lookup_dcookie, (unsigned long)(cookie >> 32), (unsigned long)(cookie & 0xffffffff), buf, size); } +#elif (defined(__mips__) && (_MIPS_SIM == _MIPS_SIM_ABI32)) /*_MIPSEL */ +static inline int lookup_dcookie(cookie_t cookie, char * buf, size_t size) +{ + return syscall(__NR_lookup_dcookie, + (unsigned long)(cookie & 0xffffffff), + (unsigned long)(cookie >> 32), buf, size); +} #else static inline int lookup_dcookie(cookie_t cookie, char * buf, size_t size) { |
From: John L. <le...@mo...> - 2005-10-17 23:34:48
|
On Mon, Oct 17, 2005 at 02:44:07PM -0700, David Daney wrote: > This patch fixes the lookup_dcookie for the MIPS o32 ABI. Although I Applied. I don't know MIPS and haven't checked, so I hope nothing has been broken here... thanks, john |
From: Ralf B. <ra...@li...> - 2005-10-18 11:45:49
|
On Mon, Oct 17, 2005 at 02:44:07PM -0700, David Daney wrote: > This patch fixes the lookup_dcookie for the MIPS o32 ABI. Although I > only tested with little-endian, the big-endian case needed fixing as > well but is untested (but what are the chances that this is not the > correct fix?). > > This is the only patch I needed to get the user space oprofile > programs to work for mipsel-linux. > > I am CCing the linux-mips list as this may be of interest there as well. Good catch. > 2005-10-17 David Daney <dd...@av...> > > * daemon/opd_cookie.c (lookup_dcookie): Handle MIPS o32 for both big > and little endian. > > Index: oprofile/daemon/opd_cookie.c > =================================================================== > RCS file: /cvsroot/oprofile/oprofile/daemon/opd_cookie.c,v > retrieving revision 1.19 > diff -p -a -u -r1.19 opd_cookie.c > --- oprofile/daemon/opd_cookie.c 26 May 2005 00:00:02 -0000 1.19 > +++ oprofile/daemon/opd_cookie.c 17 Oct 2005 21:29:13 -0000 > @@ -60,12 +60,21 @@ > #endif /* __NR_lookup_dcookie */ > > #if (defined(__powerpc__) && !defined(__powerpc64__)) || defined(__hppa__)\ > - || (defined(__s390__) && !defined(__s390x__)) > + || (defined(__s390__) && !defined(__s390x__)) \ > + || (defined(__mips__) && (_MIPS_SIM == _MIPS_SIM_ABI32) \ > + && defined(_MIPSEB)) Small nit - please use __MIPSEB__ rsp. __MIPSEL__; I think there are some compilers floating around that don't define the single underscore variant. Thanks, Ralf |
From: John L. <le...@mo...> - 2005-10-18 23:25:25
|
On Tue, Oct 18, 2005 at 12:45:26PM +0100, Ralf Baechle wrote: > > + && defined(_MIPSEB)) > > Small nit - please use __MIPSEB__ rsp. __MIPSEL__; I think there are I made it so; David, please check. thanks john |
From: David D. <dd...@av...> - 2005-10-18 23:36:01
|
John Levon wrote: > On Tue, Oct 18, 2005 at 12:45:26PM +0100, Ralf Baechle wrote: > > >>>+ && defined(_MIPSEB)) >> >>Small nit - please use __MIPSEB__ rsp. __MIPSEL__; I think there are > > > I made it so; David, please check. > I just did a cvs update and see no change. Perhaps I misunderstand. Would you like me to make and test a patch? I could... David Daney |
From: John L. <le...@mo...> - 2005-10-18 23:37:36
|
On Tue, Oct 18, 2005 at 04:35:52PM -0700, David Daney wrote: > I just did a cvs update and see no change. Perhaps I misunderstand. > Would you like me to make and test a patch? I could... anoncvs takes a while to update I think. john |
From: Geert U. <ge...@li...> - 2005-10-19 09:08:09
|
On Wed, 19 Oct 2005, John Levon wrote: > On Tue, Oct 18, 2005 at 04:35:52PM -0700, David Daney wrote: > > I just did a cvs update and see no change. Perhaps I misunderstand. > > Would you like me to make and test a patch? I could... > > anoncvs takes a while to update I think. AFAIK, it's no longer updated. Use git. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@li... In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds |
From: Thiemo S. <th...@ne...> - 2005-10-19 15:49:00
|
Ralf Baechle wrote: > On Mon, Oct 17, 2005 at 02:44:07PM -0700, David Daney wrote: > > > This patch fixes the lookup_dcookie for the MIPS o32 ABI. Although I > > only tested with little-endian, the big-endian case needed fixing as > > well but is untested (but what are the chances that this is not the > > correct fix?). > > > > This is the only patch I needed to get the user space oprofile > > programs to work for mipsel-linux. > > > > I am CCing the linux-mips list as this may be of interest there as well. > > Good catch. > > > 2005-10-17 David Daney <dd...@av...> > > > > * daemon/opd_cookie.c (lookup_dcookie): Handle MIPS o32 for both big > > and little endian. > > > > Index: oprofile/daemon/opd_cookie.c > > =================================================================== > > RCS file: /cvsroot/oprofile/oprofile/daemon/opd_cookie.c,v > > retrieving revision 1.19 > > diff -p -a -u -r1.19 opd_cookie.c > > --- oprofile/daemon/opd_cookie.c 26 May 2005 00:00:02 -0000 1.19 > > +++ oprofile/daemon/opd_cookie.c 17 Oct 2005 21:29:13 -0000 > > @@ -60,12 +60,21 @@ > > #endif /* __NR_lookup_dcookie */ > > > > #if (defined(__powerpc__) && !defined(__powerpc64__)) || defined(__hppa__)\ > > - || (defined(__s390__) && !defined(__s390x__)) > > + || (defined(__s390__) && !defined(__s390x__)) \ > > + || (defined(__mips__) && (_MIPS_SIM == _MIPS_SIM_ABI32) \ > > + && defined(_MIPSEB)) > > Small nit - please use __MIPSEB__ rsp. __MIPSEL__; I think there are > some compilers floating around that don't define the single underscore > variant. AFAIR it's the other way, some compilers fail to define __MIPSEB__ and/or __MIPSEB but all have _MIPSEB. Thiemo |
From: Ralf B. <ra...@li...> - 2005-10-19 15:55:39
|
On Wed, Oct 19, 2005 at 05:48:43PM +0200, Thiemo Seufer wrote: > Date: Wed, 19 Oct 2005 17:48:43 +0200 > To: Ralf Baechle <ra...@li...> > Cc: David Daney <dd...@av...>, > opr...@li..., lin...@li... > Subject: Re: [Patch] Fix lookup_dcookie for MIPS o32 > Content-Type: text/plain; charset=us-ascii > From: Thiemo Seufer <th...@ne...> > > Ralf Baechle wrote: > > On Mon, Oct 17, 2005 at 02:44:07PM -0700, David Daney wrote: > > > > > This patch fixes the lookup_dcookie for the MIPS o32 ABI. Although I > > > only tested with little-endian, the big-endian case needed fixing as > > > well but is untested (but what are the chances that this is not the > > > correct fix?). > > > > > > This is the only patch I needed to get the user space oprofile > > > programs to work for mipsel-linux. > > > > > > I am CCing the linux-mips list as this may be of interest there as well. > > > > Good catch. > > > > > 2005-10-17 David Daney <dd...@av...> > > > > > > * daemon/opd_cookie.c (lookup_dcookie): Handle MIPS o32 for both big > > > and little endian. > > > > > > Index: oprofile/daemon/opd_cookie.c > > > =================================================================== > > > RCS file: /cvsroot/oprofile/oprofile/daemon/opd_cookie.c,v > > > retrieving revision 1.19 > > > diff -p -a -u -r1.19 opd_cookie.c > > > --- oprofile/daemon/opd_cookie.c 26 May 2005 00:00:02 -0000 1.19 > > > +++ oprofile/daemon/opd_cookie.c 17 Oct 2005 21:29:13 -0000 > > > @@ -60,12 +60,21 @@ > > > #endif /* __NR_lookup_dcookie */ > > > > > > #if (defined(__powerpc__) && !defined(__powerpc64__)) || defined(__hppa__)\ > > > - || (defined(__s390__) && !defined(__s390x__)) > > > + || (defined(__s390__) && !defined(__s390x__)) \ > > > + || (defined(__mips__) && (_MIPS_SIM == _MIPS_SIM_ABI32) \ > > > + && defined(_MIPSEB)) > > > > Small nit - please use __MIPSEB__ rsp. __MIPSEL__; I think there are > > some compilers floating around that don't define the single underscore > > variant. > > AFAIR it's the other way, some compilers fail to define __MIPSEB__ and/or > __MIPSEB but all have _MIPSEB. None of these compilers would _ever_ have been able to compile a kernel without the __*__ variant. Ralf |
From: Ralf B. <ra...@li...> - 2005-10-19 10:41:32
|
On Wed, Oct 19, 2005 at 11:07:55AM +0200, Geert Uytterhoeven wrote: > On Wed, 19 Oct 2005, John Levon wrote: > > On Tue, Oct 18, 2005 at 04:35:52PM -0700, David Daney wrote: > > > I just did a cvs update and see no change. Perhaps I misunderstand. > > > Would you like me to make and test a patch? I could... > > > > anoncvs takes a while to update I think. > > AFAIK, it's no longer updated. Use git. This is the userspace oprofile tools, not the kernel. Last I checked Sourceforge was still on the cvs. Ralf |
From: Geert U. <ge...@li...> - 2005-10-19 11:21:57
|
On Wed, 19 Oct 2005, Ralf Baechle wrote: > On Wed, Oct 19, 2005 at 11:07:55AM +0200, Geert Uytterhoeven wrote: > > On Wed, 19 Oct 2005, John Levon wrote: > > > On Tue, Oct 18, 2005 at 04:35:52PM -0700, David Daney wrote: > > > > I just did a cvs update and see no change. Perhaps I misunderstand. > > > > Would you like me to make and test a patch? I could... > > > > > > anoncvs takes a while to update I think. > > > > AFAIK, it's no longer updated. Use git. > > This is the userspace oprofile tools, not the kernel. Last I checked > Sourceforge was still on the cvs. I stand corrected :-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@li... In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds |