From: Maynard Johnson <maynardj@us...> - 2012-11-30 15:18:45
On 11/30/2012 02:28 AM, Ross Lagerwall wrote:
> Found with valgrind.
Patch committed. Thanks! I had run operf under Valgrind, too, but this bug was committed after my Valgrind run. But Coverity *was* run against the oprofile source after this bug was introduced . . . and I'm surprised it didn't catch it.
> Signed-off-by: Ross Lagerwall <rosslagerwall@...>
> libperf_events/operf_counter.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/libperf_events/operf_counter.cpp b/libperf_events/operf_counter.cpp
> index 2c1c9dd..a02c566 100644
> --- a/libperf_events/operf_counter.cpp
> +++ b/libperf_events/operf_counter.cpp
> @@ -871,7 +871,7 @@ int operf_read::convertPerfData(void)
> strcat(cbuf, "/abi");
> - if (inputFname.empty())
> + if (!inputFname.empty())