oprofile-list — Discussion of oprofile for users and developers

Re: [PATCH] Add Broadcom Brahma-B53 CPU implementor and part number

[William C. <wc...@re...>]

On 12/9/24 19:02, Florian Fainelli wrote:
> Broadcom's Brahma-B53 CPU features a PMU which is 100% software
> compatible with those found on Cortex-A53 designs. Add the required
> code to recognize the implementor id (0x42) and the Brahma-B53 part
> number (0x100) and return "arm/armv8-ca53" so we can utilize the PMU.
> 
> Signed-off-by: Florian Fainelli <flo...@br...>
> ---
>  libop/op_cpu_type.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/libop/op_cpu_type.c b/libop/op_cpu_type.c
> index 3aab4a2d418d..69e9098cf516 100644
> --- a/libop/op_cpu_type.c
> +++ b/libop/op_cpu_type.c
> @@ -430,6 +430,8 @@ static op_cpu _get_arm_cpu_type(void)
>  		switch (cpuid) {
>  		case 0x00f:
>  			return op_get_cpu_number("arm/armv7-ca15");
> +		case 0x100:
> +			return op_get_cpu_number("arm/armv8-ca53");
>  		case 0x516:
>  			return op_get_cpu_number("arm/armv8-thunderx2");
>  		}

Hi,

The patch looks reasonable and it has been merged into the upstream oprofile git master repository.

-Will

[PATCH] Add Broadcom Brahma-B53 CPU implementor and part number

[Florian F. <flo...@br...>]

Broadcom's Brahma-B53 CPU features a PMU which is 100% software
compatible with those found on Cortex-A53 designs. Add the required
code to recognize the implementor id (0x42) and the Brahma-B53 part
number (0x100) and return "arm/armv8-ca53" so we can utilize the PMU.

Signed-off-by: Florian Fainelli <flo...@br...>
---
 libop/op_cpu_type.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libop/op_cpu_type.c b/libop/op_cpu_type.c
index 3aab4a2d418d..69e9098cf516 100644
--- a/libop/op_cpu_type.c
+++ b/libop/op_cpu_type.c
@@ -430,6 +430,8 @@ static op_cpu _get_arm_cpu_type(void)
 		switch (cpuid) {
 		case 0x00f:
 			return op_get_cpu_number("arm/armv7-ca15");
+		case 0x100:
+			return op_get_cpu_number("arm/armv8-ca53");
 		case 0x516:
 			return op_get_cpu_number("arm/armv8-thunderx2");
 		}
-- 
2.34.1

Re: Help needed

[Giri P. <sha...@gm...>]

Thanks a lot Will and William for your responses. My apologies for being
novice in this aspect:

1) My program looks like this. [Just to learn operf]
























*#include <iostream>using namespace std;void fun1(){  for(auto i = 0; i <
1000000000; i++) {     std::cout << "Fun1" << endl;  }}void fun2(){
for(auto i = 0; i < 1000000000; i++) {     std::cout << "Fun2" << endl;
}}int main(){   fun1();   fun2();}*


2) I ran the command : *operf -g ./a.out*

3) It ran for almost 20 minutes and then I killed the process.

4) Can you please let me know how to run opreport to : get the call graph *with
details of Functions fun1 and fun2 *with details such as *how many cycles
they consumed, how many times they're called* etc.

Regards,
Giri Prasad


On Tue, Apr 5, 2022 at 9:16 PM will schmidt <wil...@vn...>
wrote:

> On Tue, 2022-04-05 at 15:29 +0530, Giri Prasad wrote:
> >
> > 1) I installed operf in linux machine, below is the version:
> >
> > operf: oprofile 1.3.0 compiled on Feb  2 2020 20:33:34
> >
>
> > 2) I wrote a simple program and ran : operf ./a.out
> >
> > 3) it generated the folder: oprofile_data
> >
> > 4) when i run opreport as below:
> >
> > ##> opreport session:oprofile_data event:DATA_MEM_REFS
> > Using /home/prasadgi/tools/cpp/oprofile_data/samples/ for samples
> > directory.
> > opreport error: No sample found: Please specify a session containing
> > sample data.
> >
> > Please help what is missing ?
>
>
> Most likely the program did not run long enough or simply did not
> trigger any DATA_MEM_REFS events.
>
> Does opreport give you any output if
> you leave off the "event:" qualifier?
>
> Thanks
> -Will (Schmidt)
>
>
> >
> > Regards,
> > Giri Prasad
> > _______________________________________________
> > oprofile-list mailing list
> > opr...@li...
> > https://lists.sourceforge.net/lists/listinfo/oprofile-list
>
>

Re: Help needed

[will s. <wil...@vn...>]

On Tue, 2022-04-05 at 15:29 +0530, Giri Prasad wrote:
> 
> 1) I installed operf in linux machine, below is the version:
> 
> operf: oprofile 1.3.0 compiled on Feb  2 2020 20:33:34
> 

> 2) I wrote a simple program and ran : operf ./a.out
> 
> 3) it generated the folder: oprofile_data
> 
> 4) when i run opreport as below:
> 
> ##> opreport session:oprofile_data event:DATA_MEM_REFS
> Using /home/prasadgi/tools/cpp/oprofile_data/samples/ for samples
> directory.
> opreport error: No sample found: Please specify a session containing
> sample data.
> 
> Please help what is missing ?

 
Most likely the program did not run long enough or simply did not
trigger any DATA_MEM_REFS events.

Does opreport give you any output if
you leave off the "event:" qualifier? 

Thanks
-Will (Schmidt)


> 
> Regards,
> Giri Prasad
> _______________________________________________
> oprofile-list mailing list
> opr...@li...
> https://lists.sourceforge.net/lists/listinfo/oprofile-list

Re: Help needed

[William C. <wc...@re...>]

On 4/5/22 05:59, Giri Prasad wrote:
> 1) I installed operf in linux machine, below is the version:
> 
> operf: oprofile 1.3.0 compiled on Feb  2 2020 20:33:34
> 
> 2) I wrote a simple program and ran : *operf ./a.out*
> 
> 3) it generated the folder: *oprofile_data*
> *
> *
> 4) when i run opreport as below:
> *
> *
> *##> opreport session:oprofile_data event:DATA_MEM_REFS
> Using /home/prasadgi/tools/cpp/oprofile_data/samples/ for samples directory.
> opreport error: No sample found: Please specify a session containing
> sample data.*
> *
> *
> *Please help what is missing ?*
> *
> *
> Regards,
> Giri Prasad
> 
> 
> _______________________________________________
> oprofile-list mailing list
> opr...@li...
> https://lists.sourceforge.net/lists/listinfo/oprofile-list

Hi,

By default operf is going to use a clock cycle event to record samples .   You should see samples if you do "opreport".  However, if the program runs for a very short amount of time there might not be enough events (cycles) to trigger a sample.  If you want to get samples of the DATA_MEM_REFS you are going to need to specify the events with the --events / -e option for operf:


https://oprofile.sourceforge.io/doc/controlling-profiler.html#controlling-operf

You might also consider using linux perf:

https://perf.wiki.kernel.org/index.php/Main_Page

-Will

Help needed

[Giri P. <sha...@gm...>]

1) I installed operf in linux machine, below is the version:

operf: oprofile 1.3.0 compiled on Feb  2 2020 20:33:34

2) I wrote a simple program and ran : *operf ./a.out*

3) it generated the folder: *oprofile_data*

4) when i run opreport as below:




*##> opreport session:oprofile_data event:DATA_MEM_REFSUsing
/home/prasadgi/tools/cpp/oprofile_data/samples/ for samples
directory.opreport error: No sample found: Please specify a session
containingsample data.*

*Please help what is missing ?*

Regards,
Giri Prasad

[PATCH] oprofile: fix build on gcc-12

[Sergei T. <sl...@gm...>]

`gcc-12` will forbid std::string(nullptr_t) constructors
(as they never had a defined behaviour):

    operf_stats.cpp:182:24: error: use of deleted function 'std::__cxx11::basic_string...; std::nullptr_t = std::nullptr_t]'
      182 |                 return NULL;
          |                        ^~~~

Signed-off-by: Sergei Trofimovich <sl...@gm...>
---
 libperf_events/operf_stats.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libperf_events/operf_stats.cpp b/libperf_events/operf_stats.cpp
index 3cc28a75..a7bd0aec 100644
--- a/libperf_events/operf_stats.cpp
+++ b/libperf_events/operf_stats.cpp
@@ -179,7 +179,7 @@ static string create_stats_dir(string const & cur_sampledir)
 	if (rc && (errno != EEXIST)) {
 		cerr << "Error trying to create stats dir. " << endl;
 		perror("mkdir failed with");
-		return NULL;
+		return "";
 	}
 	return stats_dir;
 }
-- 
2.33.1

Re: [PATCH 02/29] alpha: Avoid comma separated statements

[Joe P. <jo...@pe...>]

On Tue, 2021-02-16 at 15:39 +0100, Robert Richter wrote:
> On 30.01.21 10:54:42, Joe Perches wrote:
> > On Mon, 2020-08-24 at 21:55 -0700, Joe Perches wrote:
> > > Use semicolons and braces.
> > 
> > ping?
> > 
> > > 
> > > Signed-off-by: Joe Perches <jo...@pe...>
> > > ---
> > >  arch/alpha/kernel/pci_iommu.c      |  8 +++++---
> > >  arch/alpha/oprofile/op_model_ev4.c | 22 ++++++++++++++--------
> > >  arch/alpha/oprofile/op_model_ev5.c |  8 +++++---
> 
> This patch should be rebased as oprofile is going to be removed in
> 5.12. A branch is in linux-next.

git am --include=arch/alpha/kernel/pci_iommu.c

Re: [PATCH 02/29] alpha: Avoid comma separated statements

[Robert R. <rr...@ke...>]

On 30.01.21 10:54:42, Joe Perches wrote:
> On Mon, 2020-08-24 at 21:55 -0700, Joe Perches wrote:
> > Use semicolons and braces.
> 
> ping?
> 
> > 
> > Signed-off-by: Joe Perches <jo...@pe...>
> > ---
> >  arch/alpha/kernel/pci_iommu.c      |  8 +++++---
> >  arch/alpha/oprofile/op_model_ev4.c | 22 ++++++++++++++--------
> >  arch/alpha/oprofile/op_model_ev5.c |  8 +++++---

This patch should be rebased as oprofile is going to be removed in
5.12. A branch is in linux-next.

-Robert

> >  3 files changed, 24 insertions(+), 14 deletions(-)

Re: [PATCH 02/29] alpha: Avoid comma separated statements

[Joe P. <jo...@pe...>]

On Mon, 2020-08-24 at 21:55 -0700, Joe Perches wrote:
> Use semicolons and braces.

ping?

> 
> Signed-off-by: Joe Perches <jo...@pe...>
> ---
>  arch/alpha/kernel/pci_iommu.c      |  8 +++++---
>  arch/alpha/oprofile/op_model_ev4.c | 22 ++++++++++++++--------
>  arch/alpha/oprofile/op_model_ev5.c |  8 +++++---
>  3 files changed, 24 insertions(+), 14 deletions(-)
> 
> diff --git a/arch/alpha/kernel/pci_iommu.c b/arch/alpha/kernel/pci_iommu.c
> index 81037907268d..b8af7ad6c607 100644
> --- a/arch/alpha/kernel/pci_iommu.c
> +++ b/arch/alpha/kernel/pci_iommu.c
> @@ -161,10 +161,12 @@ iommu_arena_find_pages(struct device *dev, struct pci_iommu_arena *arena,
>  			goto again;
>  		}
>  
> 
> -		if (ptes[p+i])
> -			p = ALIGN(p + i + 1, mask + 1), i = 0;
> -		else
> +		if (ptes[p+i]) {
> +			p = ALIGN(p + i + 1, mask + 1);
> +			i = 0;
> +		} else {
>  			i = i + 1;
> +		}
>  	}
>  
> 
>  	if (i < n) {
> diff --git a/arch/alpha/oprofile/op_model_ev4.c b/arch/alpha/oprofile/op_model_ev4.c
> index 086a0d5445c5..004f80a4291f 100644
> --- a/arch/alpha/oprofile/op_model_ev4.c
> +++ b/arch/alpha/oprofile/op_model_ev4.c
> @@ -46,18 +46,24 @@ ev4_reg_setup(struct op_register_config *reg,
>  	   map it onto one of the possible values, and write it back.  */
>  
> 
>  	count = ctr[0].count;
> -	if (count <= 4096)
> -		count = 4096, hilo = 1;
> -	else
> -		count = 65536, hilo = 0;
> +	if (count <= 4096) {
> +		count = 4096;
> +		hilo = 1;
> +	} else {
> +		count = 65536;
> +		hilo = 0;
> +	}
>  	ctr[0].count = count;
>  	ctl |= (ctr[0].enabled && hilo) << 3;
>  
> 
>  	count = ctr[1].count;
> -	if (count <= 256)
> -		count = 256, hilo = 1;
> -	else
> -		count = 4096, hilo = 0;
> +	if (count <= 256) {
> +		count = 256;
> +		hilo = 1;
> +	} else {
> +		count = 4096;
> +		hilo = 0;
> +	}
>  	ctr[1].count = count;
>  	ctl |= (ctr[1].enabled && hilo);
>  
> 
> diff --git a/arch/alpha/oprofile/op_model_ev5.c b/arch/alpha/oprofile/op_model_ev5.c
> index c300f5ef3482..6f52244e1181 100644
> --- a/arch/alpha/oprofile/op_model_ev5.c
> +++ b/arch/alpha/oprofile/op_model_ev5.c
> @@ -92,9 +92,11 @@ common_reg_setup(struct op_register_config *reg,
>  		if (!ctr[i].enabled)
>  			continue;
>  
> 
> -		if (count <= 256)
> -			count = 256, hilo = 3, max = 256;
> -		else {
> +		if (count <= 256) {
> +			max = 256;
> +			hilo = 3;
> +			count = 256;
> +		} else {
>  			max = (i == 2 ? 16384 : 65536);
>  			hilo = 2;
>  			if (count > max)

Re: [PATCH 09/18] arch: parisc: Remove CONFIG_OPROFILE support

[Helge D. <de...@gm...>]

On 1/14/21 12:35 PM, Viresh Kumar wrote:
> The "oprofile" user-space tools don't use the kernel OPROFILE support
> any more, and haven't in a long time. User-space has been converted to
> the perf interfaces.
>
> Remove the old oprofile's architecture specific support.
>
> Suggested-by: Christoph Hellwig <hc...@in...>
> Suggested-by: Linus Torvalds <tor...@li...> Signed-off-by: Viresh Kumar <vir...@li...>

For parisc parts:

Acked-by: Helge Deller <de...@gm...> # parisc

Thanks!
Helge

> ---
>  arch/parisc/Kconfig           |  1 -
>  arch/parisc/Makefile          |  2 --
>  arch/parisc/oprofile/Makefile | 10 ----------
>  arch/parisc/oprofile/init.c   | 23 -----------------------
>  4 files changed, 36 deletions(-)
>  delete mode 100644 arch/parisc/oprofile/Makefile
>  delete mode 100644 arch/parisc/oprofile/init.c
>
> diff --git a/arch/parisc/Kconfig b/arch/parisc/Kconfig
> index 78b17621ee4a..c2216e53fa81 100644
> --- a/arch/parisc/Kconfig
> +++ b/arch/parisc/Kconfig
> @@ -4,7 +4,6 @@ config PARISC
>  	select ARCH_32BIT_OFF_T if !64BIT
>  	select ARCH_MIGHT_HAVE_PC_PARPORT
>  	select HAVE_IDE
> -	select HAVE_OPROFILE
>  	select HAVE_FUNCTION_TRACER
>  	select HAVE_FUNCTION_GRAPH_TRACER
>  	select HAVE_SYSCALL_TRACEPOINTS
> diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
> index 5140c602207f..7d9f71aa829a 100644
> --- a/arch/parisc/Makefile
> +++ b/arch/parisc/Makefile
> @@ -116,8 +116,6 @@ kernel-y			:= mm/ kernel/ math-emu/
>  core-y	+= $(addprefix arch/parisc/, $(kernel-y))
>  libs-y	+= arch/parisc/lib/ $(LIBGCC)
>
> -drivers-$(CONFIG_OPROFILE)		+= arch/parisc/oprofile/
> -
>  boot	:= arch/parisc/boot
>
>  PALO := $(shell if (which palo 2>&1); then : ; \
> diff --git a/arch/parisc/oprofile/Makefile b/arch/parisc/oprofile/Makefile
> deleted file mode 100644
> index 86a1ccc328eb..000000000000
> --- a/arch/parisc/oprofile/Makefile
> +++ /dev/null
> @@ -1,10 +0,0 @@
> -# SPDX-License-Identifier: GPL-2.0
> -obj-$(CONFIG_OPROFILE) += oprofile.o
> -
> -DRIVER_OBJS = $(addprefix ../../../drivers/oprofile/, \
> -		oprof.o cpu_buffer.o buffer_sync.o \
> -		event_buffer.o oprofile_files.o \
> -		oprofilefs.o oprofile_stats.o \
> -		timer_int.o )
> -
> -oprofile-y				:= $(DRIVER_OBJS) init.o
> diff --git a/arch/parisc/oprofile/init.c b/arch/parisc/oprofile/init.c
> deleted file mode 100644
> index 026cba2af07a..000000000000
> --- a/arch/parisc/oprofile/init.c
> +++ /dev/null
> @@ -1,23 +0,0 @@
> -/**
> - * @file init.c
> - *
> - * @remark Copyright 2002 OProfile authors
> - * @remark Read the file COPYING
> - *
> - * @author John Levon <le...@mo...>
> - */
> -
> -#include <linux/errno.h>
> -#include <linux/init.h>
> -#include <linux/kernel.h>
> -#include <linux/oprofile.h>
> -
> -int __init oprofile_arch_init(struct oprofile_operations *ops)
> -{
> -	return -ENODEV;
> -}
> -
> -
> -void oprofile_arch_exit(void)
> -{
> -}
>

Re: [PATCH 00/18] drivers: Remove oprofile and dcookies

[Thomas G. <tg...@li...>]

On Thu, Jan 14 2021 at 17:04, Viresh Kumar wrote:
> The "oprofile" user-space tools don't use the kernel OPROFILE support
> any more, and haven't in a long time. User-space has been converted to
> the perf interfaces.
>
> Remove oprofile and dcookies (whose only user is oprofile) support from
> the kernel.

Yay!

Acked-by: Thomas Gleixner <tg...@li...>

Re: [PATCH 00/18] drivers: Remove oprofile and dcookies

[Viresh K. <vir...@li...>]

On 14-01-21, 09:51, Linus Torvalds wrote:
> On Thu, Jan 14, 2021 at 3:34 AM Viresh Kumar <vir...@li...> wrote:
> >
> > This is build/boot tested by kernel test robot (Intel) and Linaro's
> > Tuxmake[2] for a lot of architectures and no failures were reported.
> 
> Can you make sure this is in linux-next, and we'll get this in for 5.12?

This series is in linux-next now.

-- 
viresh

Re: [PATCH 10/18] arch: powerpc: Stop building and using oprofile

[Viresh K. <vir...@li...>]

On 14-01-21, 17:05, Viresh Kumar wrote:
> The "oprofile" user-space tools don't use the kernel OPROFILE support
> any more, and haven't in a long time. User-space has been converted to
> the perf interfaces.
> 
> This commits stops building oprofile for powerpc and removes any
> reference to it from directories in arch/powerpc/ apart from
> arch/powerpc/oprofile, which will be removed in the next commit (this is
> broken into two commits as the size of the commit became very big, ~5k
> lines).
> 
> Note that the member "oprofile_cpu_type" in "struct cpu_spec" isn't
> removed as it was also used by other parts of the code.
> 
> Suggested-by: Christoph Hellwig <hc...@in...>
> Suggested-by: Linus Torvalds <tor...@li...>
> Signed-off-by: Viresh Kumar <vir...@li...>
> ---
>  arch/powerpc/Kconfig                          |   1 -
>  arch/powerpc/Makefile                         |   2 -
>  arch/powerpc/configs/44x/akebono_defconfig    |   1 -
>  arch/powerpc/configs/44x/currituck_defconfig  |   1 -
>  arch/powerpc/configs/44x/fsp2_defconfig       |   1 -
>  arch/powerpc/configs/44x/iss476-smp_defconfig |   1 -
>  arch/powerpc/configs/cell_defconfig           |   1 -
>  arch/powerpc/configs/g5_defconfig             |   1 -
>  arch/powerpc/configs/maple_defconfig          |   1 -
>  arch/powerpc/configs/pasemi_defconfig         |   1 -
>  arch/powerpc/configs/pmac32_defconfig         |   1 -
>  arch/powerpc/configs/powernv_defconfig        |   1 -
>  arch/powerpc/configs/ppc64_defconfig          |   1 -
>  arch/powerpc/configs/ppc64e_defconfig         |   1 -
>  arch/powerpc/configs/ppc6xx_defconfig         |   1 -
>  arch/powerpc/configs/ps3_defconfig            |   1 -
>  arch/powerpc/configs/pseries_defconfig        |   1 -
>  arch/powerpc/include/asm/cputable.h           |  20 ---
>  arch/powerpc/include/asm/oprofile_impl.h      | 135 ------------------
>  arch/powerpc/include/asm/spu.h                |  33 -----
>  arch/powerpc/kernel/cputable.c                |  67 ---------
>  arch/powerpc/kernel/dt_cpu_ftrs.c             |   2 -
>  arch/powerpc/platforms/cell/Kconfig           |   5 -
>  arch/powerpc/platforms/cell/spu_notify.c      |  55 -------

+ this..

diff --git a/arch/powerpc/platforms/cell/Makefile b/arch/powerpc/platforms/cell/Makefile
index 10064a33ca96..7ea6692f67e2 100644
--- a/arch/powerpc/platforms/cell/Makefile
+++ b/arch/powerpc/platforms/cell/Makefile
@@ -19,7 +19,6 @@ spu-priv1-$(CONFIG_PPC_CELL_COMMON)   += spu_priv1_mmio.o
 spu-manage-$(CONFIG_PPC_CELL_COMMON)   += spu_manage.o
 
 obj-$(CONFIG_SPU_BASE)                 += spu_callbacks.o spu_base.o \
-                                          spu_notify.o \
                                           spu_syscalls.o \
                                           $(spu-priv1-y) \
                                           $(spu-manage-y) \

-- 
viresh

Re: [PATCH 00/18] drivers: Remove oprofile and dcookies

[Al V. <vi...@ze...>]

On Thu, Jan 14, 2021 at 05:04:24PM +0530, Viresh Kumar wrote:
> Hello,
> 
> The "oprofile" user-space tools don't use the kernel OPROFILE support
> any more, and haven't in a long time. User-space has been converted to
> the perf interfaces.
> 
> Remove oprofile and dcookies (whose only user is oprofile) support from
> the kernel.
> 
> This was suggested here [1] earlier.
> 
> This is build/boot tested by kernel test robot (Intel) and Linaro's
> Tuxmake[2] for a lot of architectures and no failures were reported.

fs/* side is trivial (and trivially correct).

Acked-by: Al Viro <vi...@ze...>

Re: [PATCH 00/18] drivers: Remove oprofile and dcookies

[William C. <wc...@re...>]

On 1/14/21 4:50 PM, Robert Richter wrote:
> On 14.01.21 17:04:24, Viresh Kumar wrote:
>> Hello,
>>
>> The "oprofile" user-space tools don't use the kernel OPROFILE support
>> any more, and haven't in a long time. User-space has been converted to
>> the perf interfaces.
>>
>> Remove oprofile and dcookies (whose only user is oprofile) support from
>> the kernel.
>>
>> This was suggested here [1] earlier.
>>
>> This is build/boot tested by kernel test robot (Intel) and Linaro's
>> Tuxmake[2] for a lot of architectures and no failures were reported.
>>
>> --
>> Viresh
>>
>> [1] https://lore.kernel.org/lkml/CAH...@ma.../
>> [2] https://lwn.net/Articles/841624/
>>
>> Viresh Kumar (18):
>>   arch: alpha: Remove CONFIG_OPROFILE support
>>   arch: arm: Remove CONFIG_OPROFILE support
>>   arch: arc: Remove CONFIG_OPROFILE support
>>   arch: hexagon: Don't select HAVE_OPROFILE
>>   arch: ia64: Remove CONFIG_OPROFILE support
>>   arch: ia64: Remove rest of perfmon support
>>   arch: microblaze: Remove CONFIG_OPROFILE support
>>   arch: mips: Remove CONFIG_OPROFILE support
>>   arch: parisc: Remove CONFIG_OPROFILE support
>>   arch: powerpc: Stop building and using oprofile
>>   arch: powerpc: Remove oprofile
>>   arch: s390: Remove CONFIG_OPROFILE support
>>   arch: sh: Remove CONFIG_OPROFILE support
>>   arch: sparc: Remove CONFIG_OPROFILE support
>>   arch: x86: Remove CONFIG_OPROFILE support
>>   arch: xtensa: Remove CONFIG_OPROFILE support
>>   drivers: Remove CONFIG_OPROFILE support
>>   fs: Remove dcookies support
> 
> After oprofile userland moved to version 1.x, the kernel support for
> it isn't needed anymore. The switch was back in 2014 when oprofile
> started using the perf syscall:
> 
>  https://sourceforge.net/p/oprofile/oprofile/ci/ba9edea2bdfe2c9475749fc83105632bd916b96c
> 
> Since then I haven't received any significant patches to implement new
> features or add support for newer platforms in the kernel. There
> haven't been bug reports sent or questions asked on the mailing list
> for quite a while, which indicates there are no or less users. Users
> (if any) should switch to oprofile 1.x or the perf tool. No need to
> carry kernel support any longer with us.
> 
> So time to get rid of it. For the whole series:
> 
> Acked-by: Robert Richter <rr...@ke...>

The oprofile daemon that used the older oprofile kernel support was removed before OProfile 1.0 release by the following commit in August 2014:

https://sourceforge.net/p/oprofile/oprofile/ci/0c142c3a096d3e9ec42cc9b0ddad994fea60d135

At this point it makes sense to clean up the kernel and remove this unused code.

Acked-by: William Cohen <wc...@re...>

> 
> 
> _______________________________________________
> oprofile-list mailing list
> opr...@li...
> https://lists.sourceforge.net/lists/listinfo/oprofile-list
> 

RE: [PATCH 04/18] arch: hexagon: Don't select HAVE_OPROFILE

[Brian C. <bc...@co...>]

> -----Original Message-----
> From: Viresh Kumar <vir...@li...>
> Sent: Thursday, January 14, 2021 5:35 AM
...
> The "oprofile" user-space tools don't use the kernel OPROFILE support any
> more, and haven't in a long time. User-space has been converted to the
perf
> interfaces.
> 
> Don't select HAVE_OPROFILE for hexagon anymore.

Acked-by: Brian Cain <bc...@co...>

> Suggested-by: Christoph Hellwig <hc...@in...>
> Suggested-by: Linus Torvalds <tor...@li...>
> Signed-off-by: Viresh Kumar <vir...@li...>
> ---
>  arch/hexagon/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/hexagon/Kconfig b/arch/hexagon/Kconfig index
> 6e00c16a36b5..44a409967af1 100644
> --- a/arch/hexagon/Kconfig
> +++ b/arch/hexagon/Kconfig
> @@ -7,7 +7,6 @@ config HEXAGON
>  	select ARCH_32BIT_OFF_T
>  	select ARCH_HAS_SYNC_DMA_FOR_DEVICE
>  	select ARCH_NO_PREEMPT
> -	select HAVE_OPROFILE
>  	# Other pending projects/to-do items.
>  	# select HAVE_REGS_AND_STACK_ACCESS_API
>  	# select HAVE_HW_BREAKPOINT if PERF_EVENTS
> --
> 2.25.0.rc1.19.g042ed3e048af

Re: [PATCH 12/18] arch: s390: Remove CONFIG_OPROFILE support

[Heiko C. <hc...@li...>]

On Thu, Jan 14, 2021 at 05:05:25PM +0530, Viresh Kumar wrote:
> The "oprofile" user-space tools don't use the kernel OPROFILE support
> any more, and haven't in a long time. User-space has been converted to
> the perf interfaces.
> 
> Remove the old oprofile's architecture specific support.
> 
> Suggested-by: Christoph Hellwig <hc...@in...>
> Suggested-by: Linus Torvalds <tor...@li...>
> Signed-off-by: Viresh Kumar <vir...@li...>
> ---
>  arch/s390/Kconfig                 |  1 -
>  arch/s390/Makefile                |  3 ---
>  arch/s390/configs/debug_defconfig |  1 -
>  arch/s390/configs/defconfig       |  1 -
>  arch/s390/oprofile/Makefile       | 10 ---------
>  arch/s390/oprofile/init.c         | 37 -------------------------------
>  6 files changed, 53 deletions(-)
>  delete mode 100644 arch/s390/oprofile/Makefile
>  delete mode 100644 arch/s390/oprofile/init.c

Acked-by: Heiko Carstens <hc...@li...>

Re: [PATCH 00/18] drivers: Remove oprofile and dcookies

[Viresh K. <vir...@li...>]

On 15-01-21, 10:30, Arnd Bergmann wrote:
> On Fri, Jan 15, 2021 at 4:45 AM Viresh Kumar <vir...@li...> wrote:
> >
> > On 14-01-21, 20:18, Arnd Bergmann wrote:
> > > On Thu, Jan 14, 2021 at 6:51 PM Linus Torvalds
> > > <tor...@li...> wrote:
> > > >
> > > > On Thu, Jan 14, 2021 at 3:34 AM Viresh Kumar <vir...@li...> wrote:
> > > > >
> > > > > This is build/boot tested by kernel test robot (Intel) and Linaro's
> > > > > Tuxmake[2] for a lot of architectures and no failures were reported.
> > > >
> > > > Can you make sure this is in linux-next, and we'll get this in for 5.12?
> > >
> > > Hi Viresh,
> > >
> > > I can add it to the asm-generic tree for linux-next if you send me a
> > > pull request.
> >
> > I may need to update the patches a few times in the coming days and so
> > I was thinking it may be better if I ask Stephen to include a branch
> > from my tree directly instead. Will that be fine Arnd ?
> 
> Yes, of course. I assume you will also send the pull request during
> the merge window in that case.

Yes. Thanks Arnd.

-- 
viresh

Re: [PATCH 00/18] drivers: Remove oprofile and dcookies

[Arnd B. <ar...@ke...>]

On Fri, Jan 15, 2021 at 4:45 AM Viresh Kumar <vir...@li...> wrote:
>
> On 14-01-21, 20:18, Arnd Bergmann wrote:
> > On Thu, Jan 14, 2021 at 6:51 PM Linus Torvalds
> > <tor...@li...> wrote:
> > >
> > > On Thu, Jan 14, 2021 at 3:34 AM Viresh Kumar <vir...@li...> wrote:
> > > >
> > > > This is build/boot tested by kernel test robot (Intel) and Linaro's
> > > > Tuxmake[2] for a lot of architectures and no failures were reported.
> > >
> > > Can you make sure this is in linux-next, and we'll get this in for 5.12?
> >
> > Hi Viresh,
> >
> > I can add it to the asm-generic tree for linux-next if you send me a
> > pull request.
>
> I may need to update the patches a few times in the coming days and so
> I was thinking it may be better if I ask Stephen to include a branch
> from my tree directly instead. Will that be fine Arnd ?

Yes, of course. I assume you will also send the pull request during
the merge window in that case.

      Arnd

Re: [PATCH 00/18] drivers: Remove oprofile and dcookies

[Viresh K. <vir...@li...>]

+LKML (Not sure why the cover-letter didn't go to LKML but everything else).

On 14-01-21, 17:04, Viresh Kumar wrote:
> Hello,
> 
> The "oprofile" user-space tools don't use the kernel OPROFILE support
> any more, and haven't in a long time. User-space has been converted to
> the perf interfaces.
> 
> Remove oprofile and dcookies (whose only user is oprofile) support from
> the kernel.
> 
> This was suggested here [1] earlier.
> 
> This is build/boot tested by kernel test robot (Intel) and Linaro's
> Tuxmake[2] for a lot of architectures and no failures were reported.
> 
> --
> Viresh
> 
> [1] https://lore.kernel.org/lkml/CAH...@ma.../
> [2] https://lwn.net/Articles/841624/
> 
> Viresh Kumar (18):
>   arch: alpha: Remove CONFIG_OPROFILE support
>   arch: arm: Remove CONFIG_OPROFILE support
>   arch: arc: Remove CONFIG_OPROFILE support
>   arch: hexagon: Don't select HAVE_OPROFILE
>   arch: ia64: Remove CONFIG_OPROFILE support
>   arch: ia64: Remove rest of perfmon support
>   arch: microblaze: Remove CONFIG_OPROFILE support
>   arch: mips: Remove CONFIG_OPROFILE support
>   arch: parisc: Remove CONFIG_OPROFILE support
>   arch: powerpc: Stop building and using oprofile
>   arch: powerpc: Remove oprofile
>   arch: s390: Remove CONFIG_OPROFILE support
>   arch: sh: Remove CONFIG_OPROFILE support
>   arch: sparc: Remove CONFIG_OPROFILE support
>   arch: x86: Remove CONFIG_OPROFILE support
>   arch: xtensa: Remove CONFIG_OPROFILE support
>   drivers: Remove CONFIG_OPROFILE support
>   fs: Remove dcookies support
> 
>  Documentation/RCU/NMI-RCU.rst                 |    3 +-
>  .../admin-guide/kernel-parameters.txt         |   14 -
>  Documentation/kbuild/makefiles.rst            |    1 -
>  Documentation/process/magic-number.rst        |    1 -
>  .../it_IT/process/magic-number.rst            |    1 -
>  .../zh_CN/process/magic-number.rst            |    1 -
>  MAINTAINERS                                   |   11 -
>  arch/Kconfig                                  |   32 -
>  arch/alpha/Kconfig                            |    1 -
>  arch/alpha/Makefile                           |    1 -
>  arch/alpha/oprofile/Makefile                  |   20 -
>  arch/alpha/oprofile/common.c                  |  189 --
>  arch/alpha/oprofile/op_impl.h                 |   55 -
>  arch/alpha/oprofile/op_model_ev4.c            |  114 --
>  arch/alpha/oprofile/op_model_ev5.c            |  209 --
>  arch/alpha/oprofile/op_model_ev6.c            |  101 -
>  arch/alpha/oprofile/op_model_ev67.c           |  261 ---
>  arch/arc/Kconfig                              |    1 -
>  arch/arc/Makefile                             |    2 -
>  arch/arc/oprofile/Makefile                    |   10 -
>  arch/arc/oprofile/common.c                    |   23 -
>  arch/arm/Kconfig                              |    1 -
>  arch/arm/Makefile                             |    2 -
>  arch/arm/configs/bcm2835_defconfig            |    1 -
>  arch/arm/configs/cns3420vb_defconfig          |    1 -
>  arch/arm/configs/corgi_defconfig              |    1 -
>  arch/arm/configs/imx_v4_v5_defconfig          |    1 -
>  arch/arm/configs/keystone_defconfig           |    1 -
>  arch/arm/configs/multi_v5_defconfig           |    1 -
>  arch/arm/configs/mv78xx0_defconfig            |    1 -
>  arch/arm/configs/mvebu_v5_defconfig           |    1 -
>  arch/arm/configs/omap1_defconfig              |    1 -
>  arch/arm/configs/omap2plus_defconfig          |    1 -
>  arch/arm/configs/orion5x_defconfig            |    1 -
>  arch/arm/configs/pxa_defconfig                |    1 -
>  arch/arm/configs/qcom_defconfig               |    1 -
>  arch/arm/configs/socfpga_defconfig            |    1 -
>  arch/arm/configs/spitz_defconfig              |    1 -
>  arch/arm/configs/vexpress_defconfig           |    1 -
>  arch/arm/oprofile/Makefile                    |   14 -
>  arch/arm/oprofile/common.c                    |  132 --
>  arch/hexagon/Kconfig                          |    1 -
>  arch/ia64/Kconfig                             |    1 -
>  arch/ia64/Makefile                            |    1 -
>  arch/ia64/configs/bigsur_defconfig            |    1 -
>  arch/ia64/include/asm/hw_irq.h                |    1 -
>  arch/ia64/include/asm/perfmon.h               |  111 --
>  arch/ia64/include/uapi/asm/perfmon.h          |  178 --
>  .../include/uapi/asm/perfmon_default_smpl.h   |   84 -
>  arch/ia64/kernel/palinfo.c                    |   41 -
>  arch/ia64/kernel/perfmon_default_smpl.c       |  297 ---
>  arch/ia64/kernel/perfmon_generic.h            |   46 -
>  arch/ia64/kernel/perfmon_itanium.h            |    2 +-
>  arch/ia64/kernel/perfmon_mckinley.h           |  188 --
>  arch/ia64/kernel/perfmon_montecito.h          |  270 ---
>  arch/ia64/oprofile/Makefile                   |   10 -
>  arch/ia64/oprofile/backtrace.c                |  131 --
>  arch/ia64/oprofile/init.c                     |   28 -
>  arch/microblaze/Kconfig                       |    1 -
>  arch/microblaze/Makefile                      |    2 -
>  arch/microblaze/oprofile/Makefile             |   14 -
>  .../microblaze/oprofile/microblaze_oprofile.c |   22 -
>  arch/mips/Kconfig                             |    3 +-
>  arch/mips/Makefile                            |    1 -
>  arch/mips/configs/fuloong2e_defconfig         |    1 -
>  arch/mips/configs/ip32_defconfig              |    1 -
>  arch/mips/configs/lemote2f_defconfig          |    1 -
>  arch/mips/configs/mtx1_defconfig              |    1 -
>  arch/mips/configs/rs90_defconfig              |    1 -
>  .../include/asm/mach-loongson2ef/loongson.h   |    9 -
>  arch/mips/loongson2ef/fuloong-2e/irq.c        |    2 +-
>  arch/mips/loongson2ef/lemote-2f/irq.c         |    1 -
>  arch/mips/oprofile/Makefile                   |   18 -
>  arch/mips/oprofile/backtrace.c                |  177 --
>  arch/mips/oprofile/common.c                   |  147 --
>  arch/mips/oprofile/op_impl.h                  |   41 -
>  arch/mips/oprofile/op_model_loongson2.c       |  161 --
>  arch/mips/oprofile/op_model_loongson3.c       |  213 --
>  arch/mips/oprofile/op_model_mipsxx.c          |  479 -----
>  arch/parisc/Kconfig                           |    1 -
>  arch/parisc/Makefile                          |    2 -
>  arch/parisc/oprofile/Makefile                 |   10 -
>  arch/parisc/oprofile/init.c                   |   23 -
>  arch/powerpc/Kconfig                          |    1 -
>  arch/powerpc/Makefile                         |    2 -
>  arch/powerpc/configs/44x/akebono_defconfig    |    1 -
>  arch/powerpc/configs/44x/currituck_defconfig  |    1 -
>  arch/powerpc/configs/44x/fsp2_defconfig       |    1 -
>  arch/powerpc/configs/44x/iss476-smp_defconfig |    1 -
>  arch/powerpc/configs/cell_defconfig           |    1 -
>  arch/powerpc/configs/g5_defconfig             |    1 -
>  arch/powerpc/configs/maple_defconfig          |    1 -
>  arch/powerpc/configs/pasemi_defconfig         |    1 -
>  arch/powerpc/configs/pmac32_defconfig         |    1 -
>  arch/powerpc/configs/powernv_defconfig        |    1 -
>  arch/powerpc/configs/ppc64_defconfig          |    1 -
>  arch/powerpc/configs/ppc64e_defconfig         |    1 -
>  arch/powerpc/configs/ppc6xx_defconfig         |    1 -
>  arch/powerpc/configs/ps3_defconfig            |    1 -
>  arch/powerpc/configs/pseries_defconfig        |    1 -
>  arch/powerpc/include/asm/cputable.h           |   20 -
>  arch/powerpc/include/asm/oprofile_impl.h      |  135 --
>  arch/powerpc/include/asm/spu.h                |   33 -
>  arch/powerpc/kernel/cputable.c                |   67 -
>  arch/powerpc/kernel/dt_cpu_ftrs.c             |    2 -
>  arch/powerpc/oprofile/Makefile                |   19 -
>  arch/powerpc/oprofile/backtrace.c             |  120 --
>  arch/powerpc/oprofile/cell/pr_util.h          |  110 --
>  arch/powerpc/oprofile/cell/spu_profiler.c     |  248 ---
>  arch/powerpc/oprofile/cell/spu_task_sync.c    |  657 -------
>  arch/powerpc/oprofile/cell/vma_map.c          |  279 ---
>  arch/powerpc/oprofile/common.c                |  243 ---
>  arch/powerpc/oprofile/op_model_7450.c         |  207 --
>  arch/powerpc/oprofile/op_model_cell.c         | 1709 -----------------
>  arch/powerpc/oprofile/op_model_fsl_emb.c      |  380 ----
>  arch/powerpc/oprofile/op_model_pa6t.c         |  227 ---
>  arch/powerpc/oprofile/op_model_power4.c       |  438 -----
>  arch/powerpc/platforms/cell/Kconfig           |    5 -
>  arch/powerpc/platforms/cell/spu_notify.c      |   55 -
>  arch/powerpc/platforms/cell/spufs/run.c       |    4 +-
>  arch/powerpc/platforms/cell/spufs/sched.c     |    5 -
>  arch/powerpc/platforms/cell/spufs/spufs.h     |    1 -
>  arch/s390/Kconfig                             |    1 -
>  arch/s390/Makefile                            |    3 -
>  arch/s390/configs/debug_defconfig             |    1 -
>  arch/s390/configs/defconfig                   |    1 -
>  arch/s390/oprofile/Makefile                   |   10 -
>  arch/s390/oprofile/init.c                     |   37 -
>  arch/sh/Kconfig                               |    1 -
>  arch/sh/Makefile                              |    1 -
>  arch/sh/configs/espt_defconfig                |    1 -
>  arch/sh/configs/migor_defconfig               |    1 -
>  arch/sh/configs/r7780mp_defconfig             |    1 -
>  arch/sh/configs/r7785rp_defconfig             |    1 -
>  arch/sh/configs/rsk7201_defconfig             |    1 -
>  arch/sh/configs/rsk7203_defconfig             |    1 -
>  arch/sh/configs/rts7751r2d1_defconfig         |    1 -
>  arch/sh/configs/rts7751r2dplus_defconfig      |    1 -
>  arch/sh/configs/sdk7786_defconfig             |    1 -
>  arch/sh/configs/se7206_defconfig              |    1 -
>  arch/sh/configs/sh03_defconfig                |    1 -
>  arch/sh/configs/sh7724_generic_defconfig      |    1 -
>  arch/sh/configs/sh7763rdp_defconfig           |    1 -
>  arch/sh/configs/sh7770_generic_defconfig      |    1 -
>  arch/sh/configs/shx3_defconfig                |    1 -
>  arch/sh/oprofile/Makefile                     |   16 -
>  arch/sh/oprofile/backtrace.c                  |   80 -
>  arch/sh/oprofile/common.c                     |   64 -
>  arch/sparc/Kconfig                            |    1 -
>  arch/sparc/Makefile                           |    1 -
>  arch/sparc/configs/sparc64_defconfig          |    1 -
>  arch/sparc/oprofile/Makefile                  |   10 -
>  arch/sparc/oprofile/init.c                    |   87 -
>  arch/x86/Kconfig                              |    1 -
>  arch/x86/Makefile                             |    3 -
>  arch/x86/include/asm/nmi.h                    |    1 -
>  arch/x86/kernel/cpu/perfctr-watchdog.c        |   11 +-
>  arch/x86/oprofile/Makefile                    |   12 -
>  arch/x86/oprofile/backtrace.c                 |  127 --
>  arch/x86/oprofile/init.c                      |   38 -
>  arch/x86/oprofile/nmi_int.c                   |  780 --------
>  arch/x86/oprofile/op_counter.h                |   30 -
>  arch/x86/oprofile/op_model_amd.c              |  542 ------
>  arch/x86/oprofile/op_model_p4.c               |  723 -------
>  arch/x86/oprofile/op_model_ppro.c             |  245 ---
>  arch/x86/oprofile/op_x86_model.h              |   90 -
>  arch/xtensa/Kconfig                           |    1 -
>  arch/xtensa/Makefile                          |    1 -
>  arch/xtensa/configs/audio_kc705_defconfig     |    1 -
>  arch/xtensa/configs/generic_kc705_defconfig   |    1 -
>  arch/xtensa/configs/smp_lx200_defconfig       |    1 -
>  arch/xtensa/configs/xip_kc705_defconfig       |    1 -
>  arch/xtensa/kernel/stacktrace.c               |    2 +-
>  arch/xtensa/oprofile/Makefile                 |   10 -
>  arch/xtensa/oprofile/backtrace.c              |   27 -
>  arch/xtensa/oprofile/init.c                   |   26 -
>  drivers/oprofile/buffer_sync.c                |  591 ------
>  drivers/oprofile/buffer_sync.h                |   22 -
>  drivers/oprofile/cpu_buffer.c                 |  465 -----
>  drivers/oprofile/cpu_buffer.h                 |  121 --
>  drivers/oprofile/event_buffer.c               |  209 --
>  drivers/oprofile/event_buffer.h               |   40 -
>  drivers/oprofile/nmi_timer_int.c              |  157 --
>  drivers/oprofile/oprof.c                      |  286 ---
>  drivers/oprofile/oprof.h                      |   50 -
>  drivers/oprofile/oprofile_files.c             |  201 --
>  drivers/oprofile/oprofile_perf.c              |  328 ----
>  drivers/oprofile/oprofile_stats.c             |   84 -
>  drivers/oprofile/oprofile_stats.h             |   33 -
>  drivers/oprofile/oprofilefs.c                 |  300 ---
>  drivers/oprofile/timer_int.c                  |  122 --
>  fs/Makefile                                   |    1 -
>  fs/dcookies.c                                 |  356 ----
>  include/linux/dcookies.h                      |   69 -
>  include/linux/oprofile.h                      |  209 --
>  init/Kconfig                                  |    2 +-
>  kernel/sys.c                                  |    1 -
>  usr/include/Makefile                          |    2 -
>  198 files changed, 8 insertions(+), 15566 deletions(-)
>  delete mode 100644 arch/alpha/oprofile/Makefile
>  delete mode 100644 arch/alpha/oprofile/common.c
>  delete mode 100644 arch/alpha/oprofile/op_impl.h
>  delete mode 100644 arch/alpha/oprofile/op_model_ev4.c
>  delete mode 100644 arch/alpha/oprofile/op_model_ev5.c
>  delete mode 100644 arch/alpha/oprofile/op_model_ev6.c
>  delete mode 100644 arch/alpha/oprofile/op_model_ev67.c
>  delete mode 100644 arch/arc/oprofile/Makefile
>  delete mode 100644 arch/arc/oprofile/common.c
>  delete mode 100644 arch/arm/oprofile/Makefile
>  delete mode 100644 arch/arm/oprofile/common.c
>  delete mode 100644 arch/ia64/include/asm/perfmon.h
>  delete mode 100644 arch/ia64/include/uapi/asm/perfmon.h
>  delete mode 100644 arch/ia64/include/uapi/asm/perfmon_default_smpl.h
>  delete mode 100644 arch/ia64/kernel/perfmon_default_smpl.c
>  delete mode 100644 arch/ia64/kernel/perfmon_generic.h
>  delete mode 100644 arch/ia64/kernel/perfmon_mckinley.h
>  delete mode 100644 arch/ia64/kernel/perfmon_montecito.h
>  delete mode 100644 arch/ia64/oprofile/Makefile
>  delete mode 100644 arch/ia64/oprofile/backtrace.c
>  delete mode 100644 arch/ia64/oprofile/init.c
>  delete mode 100644 arch/microblaze/oprofile/Makefile
>  delete mode 100644 arch/microblaze/oprofile/microblaze_oprofile.c
>  delete mode 100644 arch/mips/oprofile/Makefile
>  delete mode 100644 arch/mips/oprofile/backtrace.c
>  delete mode 100644 arch/mips/oprofile/common.c
>  delete mode 100644 arch/mips/oprofile/op_impl.h
>  delete mode 100644 arch/mips/oprofile/op_model_loongson2.c
>  delete mode 100644 arch/mips/oprofile/op_model_loongson3.c
>  delete mode 100644 arch/mips/oprofile/op_model_mipsxx.c
>  delete mode 100644 arch/parisc/oprofile/Makefile
>  delete mode 100644 arch/parisc/oprofile/init.c
>  delete mode 100644 arch/powerpc/include/asm/oprofile_impl.h
>  delete mode 100644 arch/powerpc/oprofile/Makefile
>  delete mode 100644 arch/powerpc/oprofile/backtrace.c
>  delete mode 100644 arch/powerpc/oprofile/cell/pr_util.h
>  delete mode 100644 arch/powerpc/oprofile/cell/spu_profiler.c
>  delete mode 100644 arch/powerpc/oprofile/cell/spu_task_sync.c
>  delete mode 100644 arch/powerpc/oprofile/cell/vma_map.c
>  delete mode 100644 arch/powerpc/oprofile/common.c
>  delete mode 100644 arch/powerpc/oprofile/op_model_7450.c
>  delete mode 100644 arch/powerpc/oprofile/op_model_cell.c
>  delete mode 100644 arch/powerpc/oprofile/op_model_fsl_emb.c
>  delete mode 100644 arch/powerpc/oprofile/op_model_pa6t.c
>  delete mode 100644 arch/powerpc/oprofile/op_model_power4.c
>  delete mode 100644 arch/powerpc/platforms/cell/spu_notify.c
>  delete mode 100644 arch/s390/oprofile/Makefile
>  delete mode 100644 arch/s390/oprofile/init.c
>  delete mode 100644 arch/sh/oprofile/Makefile
>  delete mode 100644 arch/sh/oprofile/backtrace.c
>  delete mode 100644 arch/sh/oprofile/common.c
>  delete mode 100644 arch/sparc/oprofile/Makefile
>  delete mode 100644 arch/sparc/oprofile/init.c
>  delete mode 100644 arch/x86/oprofile/Makefile
>  delete mode 100644 arch/x86/oprofile/backtrace.c
>  delete mode 100644 arch/x86/oprofile/init.c
>  delete mode 100644 arch/x86/oprofile/nmi_int.c
>  delete mode 100644 arch/x86/oprofile/op_counter.h
>  delete mode 100644 arch/x86/oprofile/op_model_amd.c
>  delete mode 100644 arch/x86/oprofile/op_model_p4.c
>  delete mode 100644 arch/x86/oprofile/op_model_ppro.c
>  delete mode 100644 arch/x86/oprofile/op_x86_model.h
>  delete mode 100644 arch/xtensa/oprofile/Makefile
>  delete mode 100644 arch/xtensa/oprofile/backtrace.c
>  delete mode 100644 arch/xtensa/oprofile/init.c
>  delete mode 100644 drivers/oprofile/buffer_sync.c
>  delete mode 100644 drivers/oprofile/buffer_sync.h
>  delete mode 100644 drivers/oprofile/cpu_buffer.c
>  delete mode 100644 drivers/oprofile/cpu_buffer.h
>  delete mode 100644 drivers/oprofile/event_buffer.c
>  delete mode 100644 drivers/oprofile/event_buffer.h
>  delete mode 100644 drivers/oprofile/nmi_timer_int.c
>  delete mode 100644 drivers/oprofile/oprof.c
>  delete mode 100644 drivers/oprofile/oprof.h
>  delete mode 100644 drivers/oprofile/oprofile_files.c
>  delete mode 100644 drivers/oprofile/oprofile_perf.c
>  delete mode 100644 drivers/oprofile/oprofile_stats.c
>  delete mode 100644 drivers/oprofile/oprofile_stats.h
>  delete mode 100644 drivers/oprofile/oprofilefs.c
>  delete mode 100644 drivers/oprofile/timer_int.c
>  delete mode 100644 fs/dcookies.c
>  delete mode 100644 include/linux/dcookies.h
>  delete mode 100644 include/linux/oprofile.h
> 
> 
> base-commit: 7c53f6b671f4aba70ff15e1b05148b10d58c2837
> -- 
> 2.25.0.rc1.19.g042ed3e048af
> 

-- 
viresh

Re: [PATCH 10/18] arch: powerpc: Stop building and using oprofile

[Viresh K. <vir...@li...>]

On 14-01-21, 17:05, Viresh Kumar wrote:
> The "oprofile" user-space tools don't use the kernel OPROFILE support
> any more, and haven't in a long time. User-space has been converted to
> the perf interfaces.
> 
> This commits stops building oprofile for powerpc and removes any
> reference to it from directories in arch/powerpc/ apart from
> arch/powerpc/oprofile, which will be removed in the next commit (this is
> broken into two commits as the size of the commit became very big, ~5k
> lines).
> 
> Note that the member "oprofile_cpu_type" in "struct cpu_spec" isn't
> removed as it was also used by other parts of the code.
> 
> Suggested-by: Christoph Hellwig <hc...@in...>
> Suggested-by: Linus Torvalds <tor...@li...>
> Signed-off-by: Viresh Kumar <vir...@li...>

+ this to fix a warning:

diff --git a/arch/powerpc/platforms/cell/spufs/run.c b/arch/powerpc/platforms/cell/spufs/run.c
index 466006918003..ce52b87496d2 100644
--- a/arch/powerpc/platforms/cell/spufs/run.c
+++ b/arch/powerpc/platforms/cell/spufs/run.c
@@ -353,7 +353,6 @@ static int spu_process_callback(struct spu_context *ctx)
 long spufs_run_spu(struct spu_context *ctx, u32 *npc, u32 *event)
 {
        int ret;
-       struct spu *spu;
        u32 status;
 
        if (mutex_lock_interruptible(&ctx->run_mutex))
@@ -386,7 +385,6 @@ long spufs_run_spu(struct spu_context *ctx, u32 *npc, u32 *event)
                        mutex_lock(&ctx->state_mutex);
                        break;
                }
-               spu = ctx->spu;
                if (unlikely(test_and_clear_bit(SPU_SCHED_NOTIFY_ACTIVE,
                                                &ctx->sched_flags))) {
                        if (!(status & SPU_STATUS_STOPPED_BY_STOP))

-- 
viresh

Re: [PATCH 00/18] drivers: Remove oprofile and dcookies

[Viresh K. <vir...@li...>]

On 14-01-21, 20:18, Arnd Bergmann wrote:
> On Thu, Jan 14, 2021 at 6:51 PM Linus Torvalds
> <tor...@li...> wrote:
> >
> > On Thu, Jan 14, 2021 at 3:34 AM Viresh Kumar <vir...@li...> wrote:
> > >
> > > This is build/boot tested by kernel test robot (Intel) and Linaro's
> > > Tuxmake[2] for a lot of architectures and no failures were reported.
> >
> > Can you make sure this is in linux-next, and we'll get this in for 5.12?
> 
> Hi Viresh,
> 
> I can add it to the asm-generic tree for linux-next if you send me a
> pull request.

I may need to update the patches a few times in the coming days and so
I was thinking it may be better if I ask Stephen to include a branch
from my tree directly instead. Will that be fine Arnd ?

-- 
viresh

Re: [PATCH 03/18] arch: arc: Remove CONFIG_OPROFILE support

[Viresh K. <vir...@li...>]

On 14-01-21, 17:51, Vineet Gupta wrote:
> On 1/14/21 3:35 AM, Viresh Kumar wrote:
> > The "oprofile" user-space tools don't use the kernel OPROFILE support
> > any more, and haven't in a long time. User-space has been converted to
> > the perf interfaces.
> >
> > Remove the old oprofile's architecture specific support.
> >
> > Suggested-by: Christoph Hellwig <hc...@in...>
> > Suggested-by: Linus Torvalds <tor...@li...>
> > Signed-off-by: Viresh Kumar <vir...@li...>
> 
> Acked-by: Vineet Gupta <vg...@sy...>
> 
> I presume this doesn't need to go through ARC tree.

Yes.

-- 
viresh

Re: [PATCH 00/18] drivers: Remove oprofile and dcookies

[John L. <le...@mo...>]

On Thu, Jan 14, 2021 at 05:04:24PM +0530, Viresh Kumar wrote:

> The "oprofile" user-space tools don't use the kernel OPROFILE support
> any more, and haven't in a long time. User-space has been converted to
> the perf interfaces.
> 
> Remove oprofile and dcookies (whose only user is oprofile) support from
> the kernel.

With a fond farewell...

Acked-by: John Levon <le...@mo...>

john