From: Philippe E. <ph...@us...> - 2002-03-17 21:18:21
|
Update of /cvsroot/oprofile/oprofile/oprof_report In directory usw-pr-cvs1:/tmp/cvs-serv11311/oprofile/oprof_report Modified Files: hotspot_view.cpp hotspot_view.h op_view.h oprof_report.cpp oprofpp_view.cpp oprofpp_view.h Log Message: oprof_report : revert partially my last patch - pp : op_time small fix Index: hotspot_view.cpp =================================================================== RCS file: /cvsroot/oprofile/oprofile/oprof_report/hotspot_view.cpp,v retrieving revision 1.2 retrieving revision 1.3 diff -u -d -r1.2 -r1.3 --- hotspot_view.cpp 17 Mar 2002 00:39:43 -0000 1.2 +++ hotspot_view.cpp 17 Mar 2002 21:18:17 -0000 1.3 @@ -111,11 +111,17 @@ */ void HotspotView::do_data_change(const samples_files_t * samples_) { - symbols.clear(); - samples = samples_; samples->select_symbols(symbols, 0, 0.0, false, true); update(); +} + +/** + * do_data_destroy() - handle data destroy + */ +void HotspotView::do_data_destroy() +{ + symbols.clear(); } Index: hotspot_view.h =================================================================== RCS file: /cvsroot/oprofile/oprofile/oprof_report/hotspot_view.h,v retrieving revision 1.2 retrieving revision 1.3 diff -u -d -r1.2 -r1.3 --- hotspot_view.h 17 Mar 2002 00:39:43 -0000 1.2 +++ hotspot_view.h 17 Mar 2002 21:18:17 -0000 1.3 @@ -34,6 +34,7 @@ /// reimplemented void paintEvent(QPaintEvent *); void do_data_change(const samples_files_t *); + void do_data_destroy(); private: std::vector <const symbol_entry *> symbols; const samples_files_t * samples; Index: op_view.h =================================================================== RCS file: /cvsroot/oprofile/oprofile/oprof_report/op_view.h,v retrieving revision 1.2 retrieving revision 1.3 diff -u -d -r1.2 -r1.3 --- op_view.h 17 Mar 2002 00:39:43 -0000 1.2 +++ op_view.h 17 Mar 2002 21:18:17 -0000 1.3 @@ -33,9 +33,10 @@ notification_sended = true; } } - void set_dirty() { notification_sended = false; } + void data_destroy() { do_data_destroy(); notification_sended = false; } private: virtual void do_data_change(const samples_files_t *) = 0; + virtual void do_data_destroy() = 0; // FUTURE // virtual void do_right_click(); bool notification_sended; Index: oprof_report.cpp =================================================================== RCS file: /cvsroot/oprofile/oprofile/oprof_report/oprof_report.cpp,v retrieving revision 1.3 retrieving revision 1.4 diff -u -d -r1.3 -r1.4 --- oprof_report.cpp 17 Mar 2002 00:39:43 -0000 1.3 +++ oprof_report.cpp 17 Mar 2002 21:18:17 -0000 1.4 @@ -99,8 +99,8 @@ */ void oprof_report::mark_all_view_changed() { - oprofpp_view->set_dirty(); - hotspot_view->set_dirty(); + oprofpp_view->data_destroy(); + hotspot_view->data_destroy(); } /** Index: oprofpp_view.cpp =================================================================== RCS file: /cvsroot/oprofile/oprofile/oprof_report/oprofpp_view.cpp,v retrieving revision 1.2 retrieving revision 1.3 diff -u -d -r1.2 -r1.3 --- oprofpp_view.cpp 17 Mar 2002 00:39:43 -0000 1.2 +++ oprofpp_view.cpp 17 Mar 2002 21:18:17 -0000 1.3 @@ -248,8 +248,6 @@ */ void OprofppView::do_data_change(const samples_files_t * samples) { - view->clear(); - vector<const symbol_entry *> symbs; samples->select_symbols(symbs, 0, 0.0, false, true); @@ -257,5 +255,14 @@ for (it = symbs.begin() ; it != symbs.end() ; ++it) { new SymbolItem(view, *it, *samples); } +} + + +/** + * do_data_destroy - destroy all items in list view + */ +void OprofppView::do_data_destroy() +{ + view->clear(); } Index: oprofpp_view.h =================================================================== RCS file: /cvsroot/oprofile/oprofile/oprof_report/oprofpp_view.h,v retrieving revision 1.2 retrieving revision 1.3 diff -u -d -r1.2 -r1.3 --- oprofpp_view.h 17 Mar 2002 00:39:43 -0000 1.2 +++ oprofpp_view.h 17 Mar 2002 21:18:17 -0000 1.3 @@ -27,6 +27,7 @@ OprofppView(QListView * view); private: void do_data_change(const samples_files_t * ); + void do_data_destroy(); QListView * view; }; |