Re: forcing oprofile module to use timer mode

[Philippe E. <ph...@wa...>]

Will Cohen wrote:
> I have revised the patch based on the comments I got. I eliminated the 
> spurious include and the I shortened the variable name to 
> oprofile_timer. I kept the oprofile prefix because the variable is 
> outside the module.
> 
> I talked to Richard Henderson about adding the the same support to the 
> Alpha. He is willing to add it to the oprofile support for the Alpha. I 
> don't have an Alpha machine, so I can't really develop the code. Richard 
> said that it would be easier for him to add the Alpha version if the 
> patch was in the kernel. What needs to be done to get the patch into the 
>  2.5 development kernel?


John, diffing the four different timer_int.c in arch/ I see only
spurious diff, and this diff are here because change to x86
timer_int.c are not propagated to other arch, isn't it the
right way to provide this file in drivers/oprofile ?

Each arch will provide only the oprofile_arch_init() entry
point and the syscall wrapper, if neccessary, to cookie_lookup.

And no, sorry, I only looked if it seems feasable but have
no time to do it. The only problem is the submit process
as you'll need acceptance from each arch maintainer


$ find -name timer_int.c
./arch/i386/oprofile/timer_int.c
./arch/sparc64/oprofile/timer_int.c
./arch/ppc64/oprofile/timer_int.c
./arch/parisc/oprofile/timer_int.c

needs also modification in x64 oprofile build process
since it symlink needed file from i386 arch.

Allowing easier port of oprofile through timer_int will be
good and propagating change in timer_int.c is a pain
currently.

regards,
Phil