Re: [PATCH 09/18] arch: parisc: Remove CONFIG_OPROFILE support

[Helge D. <de...@gm...>]

On 1/14/21 12:35 PM, Viresh Kumar wrote:
> The "oprofile" user-space tools don't use the kernel OPROFILE support
> any more, and haven't in a long time. User-space has been converted to
> the perf interfaces.
>
> Remove the old oprofile's architecture specific support.
>
> Suggested-by: Christoph Hellwig <hc...@in...>
> Suggested-by: Linus Torvalds <tor...@li...> Signed-off-by: Viresh Kumar <vir...@li...>

For parisc parts:

Acked-by: Helge Deller <de...@gm...> # parisc

Thanks!
Helge

> ---
>  arch/parisc/Kconfig           |  1 -
>  arch/parisc/Makefile          |  2 --
>  arch/parisc/oprofile/Makefile | 10 ----------
>  arch/parisc/oprofile/init.c   | 23 -----------------------
>  4 files changed, 36 deletions(-)
>  delete mode 100644 arch/parisc/oprofile/Makefile
>  delete mode 100644 arch/parisc/oprofile/init.c
>
> diff --git a/arch/parisc/Kconfig b/arch/parisc/Kconfig
> index 78b17621ee4a..c2216e53fa81 100644
> --- a/arch/parisc/Kconfig
> +++ b/arch/parisc/Kconfig
> @@ -4,7 +4,6 @@ config PARISC
>  	select ARCH_32BIT_OFF_T if !64BIT
>  	select ARCH_MIGHT_HAVE_PC_PARPORT
>  	select HAVE_IDE
> -	select HAVE_OPROFILE
>  	select HAVE_FUNCTION_TRACER
>  	select HAVE_FUNCTION_GRAPH_TRACER
>  	select HAVE_SYSCALL_TRACEPOINTS
> diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
> index 5140c602207f..7d9f71aa829a 100644
> --- a/arch/parisc/Makefile
> +++ b/arch/parisc/Makefile
> @@ -116,8 +116,6 @@ kernel-y			:= mm/ kernel/ math-emu/
>  core-y	+= $(addprefix arch/parisc/, $(kernel-y))
>  libs-y	+= arch/parisc/lib/ $(LIBGCC)
>
> -drivers-$(CONFIG_OPROFILE)		+= arch/parisc/oprofile/
> -
>  boot	:= arch/parisc/boot
>
>  PALO := $(shell if (which palo 2>&1); then : ; \
> diff --git a/arch/parisc/oprofile/Makefile b/arch/parisc/oprofile/Makefile
> deleted file mode 100644
> index 86a1ccc328eb..000000000000
> --- a/arch/parisc/oprofile/Makefile
> +++ /dev/null
> @@ -1,10 +0,0 @@
> -# SPDX-License-Identifier: GPL-2.0
> -obj-$(CONFIG_OPROFILE) += oprofile.o
> -
> -DRIVER_OBJS = $(addprefix ../../../drivers/oprofile/, \
> -		oprof.o cpu_buffer.o buffer_sync.o \
> -		event_buffer.o oprofile_files.o \
> -		oprofilefs.o oprofile_stats.o \
> -		timer_int.o )
> -
> -oprofile-y				:= $(DRIVER_OBJS) init.o
> diff --git a/arch/parisc/oprofile/init.c b/arch/parisc/oprofile/init.c
> deleted file mode 100644
> index 026cba2af07a..000000000000
> --- a/arch/parisc/oprofile/init.c
> +++ /dev/null
> @@ -1,23 +0,0 @@
> -/**
> - * @file init.c
> - *
> - * @remark Copyright 2002 OProfile authors
> - * @remark Read the file COPYING
> - *
> - * @author John Levon <le...@mo...>
> - */
> -
> -#include <linux/errno.h>
> -#include <linux/init.h>
> -#include <linux/kernel.h>
> -#include <linux/oprofile.h>
> -
> -int __init oprofile_arch_init(struct oprofile_operations *ops)
> -{
> -	return -ENODEV;
> -}
> -
> -
> -void oprofile_arch_exit(void)
> -{
> -}
>