[oprof-cvs] [SF SCMS]oprofile branch wcohen/f28_fixes created. PRE_RELEASE_1_0-100-geaa4c0c6

[William C. <wc...@us...>]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "oprofile".

The branch, wcohen/f28_fixes has been created
        at  eaa4c0c67f9542c63efa656bdee59798f7abfd7d (commit)

- Log -----------------------------------------------------------------
commit eaa4c0c67f9542c63efa656bdee59798f7abfd7d
Author: William Cohen <wc...@re...>
Date:   Fri Jul 13 14:31:15 2018 -0400

    Make the always_true function signature match its use
    
    The GCC-8.1.1 compiler in Fedora 28 checks that the function
    signatures match between the declarations and uses.  The always_true
    function arguments in the declaration did not match the arguments
    being passed when the function is called causing the compiler to
    generate the following error wit the default compiler options:
    
    g++ -DHAVE_CONFIG_H -I. -I..  -I ../libabi -I ../libutil -I ../libutil++ -I ../libop -I ../libdb -I ../libperf_events -I ../libpe_utils   -W -Wall -fno-common -Werror -g -O2 -MT operf_sfile.o -MD -MP -MF .deps/operf_sfile.Tpo -c -o operf_sfile.o operf_sfile.cpp
    operf_sfile.cpp: In function ‘int operf_sfile_lru_clear()’:
    operf_sfile.cpp:549:39: error: cast between incompatible function types from ‘int (*)()’ to ‘operf_sfile_func’ {aka ‘int (*)(operf_sfile*, void*)’} [-Werror=cast-function-type]
       for_one_sfile(sf, (operf_sfile_func)always_true, NULL);
                                           ^~~~~~~~~~~
    cc1plus: all warnings being treated as errors
    make[2]: *** [Makefile:457: operf_sfile.o] Error 1

commit 39113a4c7d04b87f0b4a2cdb5a5c44259f2bb4fa
Author: William Cohen <wc...@re...>
Date:   Fri Jul 13 14:01:42 2018 -0400

    Remove problem typecasting in option_base::option_base
    
    Removing the typecast to avoid the following error with the default
    options for GCC 8.1.1 in Fedora 28:
    
    g++ -DHAVE_CONFIG_H -I. -I..  -I ../libutil++ -I ../libutil   -W -Wall -fno-common -Werror -g -O2 -MT popt_options.o -MD -MP -MF .deps/popt_options.Tpo -c -o popt_options.o popt_options.cpp
    popt_options.cpp: In constructor ‘popt::option_base::option_base(const char*, char, const char*, const char*, void*, unsigned int)’:
    popt_options.cpp:254:66: error: type qualifiers ignored on cast result type [-Werror=ignored-qualifiers]
      poptOption const opt = { name, short_name, (typeof(opt.argInfo))popt_flags,
                                                                      ^~~~~~~~~~
    cc1plus: all warnings being treated as errors
    make[2]: *** [Makefile:413: popt_options.o] Error 1

-----------------------------------------------------------------------


hooks/post-receive
-- 
oprofile