From: Maynard J. <may...@us...> - 2013-07-18 19:01:18
|
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "oprofile". The branch, master has been updated via 175ed473ebe1df3d5bcfc785f5676fa1684777cf (commit) via cec8251f6efcd30784454f17a798e66bca91de20 (commit) via 5bcf38739ef90813d9ece8c41f5e496e0082791f (commit) via a4cbf9671e241b602b30633176ecd8b640fb6c83 (commit) via e83b4fc259059ab36984a511caee486a06d17df3 (commit) via 8846630b3b2b2a6555d98d388e97bfae496f5222 (commit) via a8ab7e2a10cd70d56ad47606471a01a958dd8438 (commit) from e4754f6f05b08bfe31cd020903280935693a0aa7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 175ed473ebe1df3d5bcfc785f5676fa1684777cf Author: Maynard Johnson <may...@us...> Date: Thu Jul 18 13:45:02 2013 -0500 Post-review fixups for new ocount feature This patch fixes the issues raised during the review of the 'ocount' tool. Some of the issues were raised on the oprofile-list, and some were raised internally by users within my company. The issues raised internally were: - Bug: Compile failure with recent gcc - Request to display total time events were being counted in long output - Bug: Counting multiple events in a run mode other than 'command [args]' can result in incorrect output. For example: ocount -s -e CPU_CLK_UNHALTED,UNHALTED_REFERENCE_CYCLES Event counts (scaled) for the whole system: Event Count % time enabled CPU_CLK_UNHALTED 291,912,262 100.00 CPU_CLK_UNHALTED 27,431,626 100.00 - Bug: On ppc64 systems, event spec returned by _handle_powerpc_event_spec may contain extra garbage after the event name. - Request to change the --time-interval option to show counts just for the interval, not cumulative counts Signed-off-by: Maynard Johnson <may...@us...> commit cec8251f6efcd30784454f17a798e66bca91de20 Author: Maynard Johnson <may...@us...> Date: Thu Jul 18 13:44:28 2013 -0500 Add ocount information to user manual With the introduction of the new ocount tool, some new sections in the OProfile user manual were needed to describe its operation. Additionally, some minor changes were needed elsewhere so as to include event counting (along with profiling) where appropriate. Signed-off-by: Maynard Johnson <may...@us...> commit 5bcf38739ef90813d9ece8c41f5e496e0082791f Author: Maynard Johnson <may...@us...> Date: Thu Jul 18 13:43:54 2013 -0500 Fix problems in ocount patch set found by Coverity I ran Coverity against the oprofile source tree with the "ocount" patch set applied, and it found several issues. This patch fixes those. Signed-off-by: Maynard Johnson <may...@us...> commit a4cbf9671e241b602b30633176ecd8b640fb6c83 Author: Maynard Johnson <may...@us...> Date: Thu Jul 18 13:43:01 2013 -0500 Add manpage for new ocount tool Signed-off-by: Maynard Johnson <may...@us...> commit e83b4fc259059ab36984a511caee486a06d17df3 Author: Maynard Johnson <may...@us...> Date: Thu Jul 18 13:42:14 2013 -0500 New ocount tool and associated ocount_counter classes This patch implements the executable 'ocount' tool, as well as some classes used for opening and managing the "perf_events" file descriptors (opened via perf_event_open). Signed-off-by: Maynard Johnson <may...@us...> commit 8846630b3b2b2a6555d98d388e97bfae496f5222 Author: Maynard Johnson <may...@us...> Date: Thu Jul 18 13:41:02 2013 -0500 Add various utility routines needed by new ocount tool Signed-off-by: Maynard Johnson <may...@us...> commit a8ab7e2a10cd70d56ad47606471a01a958dd8438 Author: Maynard Johnson <may...@us...> Date: Thu Jul 18 13:39:32 2013 -0500 Add 'check_count' parameter to parse_events function For profiling, oprofile enforces a 'count' value to be included in the event specification passed by a user. It is the parse_events() function in libop/op_parse_event.c that handles that checking. But for counting events versus profiling, a 'count' value is meaningless, so this patch adds support for parse_events() to parse an event spec from either the profiling tools or the new counting tool. Signed-off-by: Maynard Johnson <may...@us...> ----------------------------------------------------------------------- Summary of changes: Makefile.am | 2 + configure.ac | 3 + doc/Makefile.am | 3 +- doc/ocount.1.in | 224 +++++++ doc/oprofile.xml | 471 +++++++++++---- libop/op_parse_event.c | 17 +- libop/op_parse_event.h | 2 +- libop/tests/alloc_counter_tests.c | 2 +- libop/tests/parse_event_tests.c | 2 +- libpe_utils/Makefile.am | 18 + libpe_utils/op_pe_utils.cpp | 940 +++++++++++++++++++++++++++++ libpe_utils/op_pe_utils.h | 47 ++ {pe_profiling => pe_counting}/Makefile.am | 17 +- pe_counting/ocount.cpp | 835 +++++++++++++++++++++++++ pe_counting/ocount_counter.cpp | 696 +++++++++++++++++++++ pe_counting/ocount_counter.h | 125 ++++ utils/ophelp.c | 12 +- 17 files changed, 3271 insertions(+), 145 deletions(-) create mode 100644 doc/ocount.1.in create mode 100644 libpe_utils/Makefile.am create mode 100644 libpe_utils/op_pe_utils.cpp create mode 100644 libpe_utils/op_pe_utils.h copy {pe_profiling => pe_counting}/Makefile.am (59%) create mode 100644 pe_counting/ocount.cpp create mode 100644 pe_counting/ocount_counter.cpp create mode 100644 pe_counting/ocount_counter.h hooks/post-receive -- oprofile |