Re: [PATCH -- v2] Update opcontrol's help and man page to indicate how to reset buffer values to defaults

[William C. <wc...@re...>]

On 08/12/2010 03:00 PM, Maynard Johnson wrote:
> On 08/12/2010 1:42 PM, Maynard Johnson wrote:
>> On 08/12/2010 12:40 PM, William Cohen wrote:
>>> On 08/06/2010 12:33 PM, Maynard Johnson wrote:
>>>> When users play around with changing buffer sizes (via opcontrol), they often want to change them back to the default values.  There is an easy way to reset to the defaults -- by passing '0' for the new buffer value -- but this technique is not documented.  This patch documents this in both 'opcontrol --help' and the opcontrol man page.
>>>>
>>>> -Maynard
>>>>
>>>> Signed-off-by:  Maynard Johnson<may...@us...>
>>>
>>> Hi Maynard,
>>>
>>> I took a look at how opcontrol works. The changes are not going to occur until the oprofile module is unloaded and reloaded. People might assume that default would be selected next time "opcontrol --start". That is when the changes to the buffer normally happens.
>>
>> Excellent point.  I'll update the patch.  I'll also add the bit that setting
>> non-default values don't take effect until after a --shutdown/start sequence.
>>
>> Thanks.
>> -Maynard
>>
>>>
>>> -Will
>>>
> 
> Will,
> Attached is the updated patch to address your review comments.  Thanks.
> 
> -Maynard
> 
> 
> Signed-off-by:  Maynard Johnson <may...@us...>
> 

Hi Maynard,

The revised text looks reasonable. One last nit. Some of the resulting lines are longer than 80 characters for "opcontrol --help". It would be nice to format those so they are 80 characters or less in length.

-Will