Re: [PATCH] oprofile: Don't report Nehalem as core_2

[Robert R. <rob...@am...>]

On 20.08.08 18:40:32, Andi Kleen wrote:
> From: Andi Kleen <ak...@li...>
> 
> This essentially reverts Linus' earlier 4b9f12a3779c548b68bc9af7d94030868ad3aa1b
> commit. Nehalem is not core_2, so it shouldn't be reported as such.
> However with the earlier arch perfmon patch it will fall back to
> arch perfmon mode now, so there is no need to fake it as core_2.
> The only drawback is that Linus will need to patch the arch perfmon
> support into his oprofile binary now, but I think he can do that.
> 
> Signed-off-by: Andi Kleen <ak...@li...>

I will send this patch upstream together with the architectural
perfmon implementation and when the userland part is upstream.

-Robert

> ---
>  arch/x86/oprofile/nmi_int.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/x86/oprofile/nmi_int.c b/arch/x86/oprofile/nmi_int.c
> index 6438c32..669a713 100644
> --- a/arch/x86/oprofile/nmi_int.c
> +++ b/arch/x86/oprofile/nmi_int.c
> @@ -418,9 +418,6 @@ static int __init ppro_init(char **cpu_type)
>  	case 15: case 23:
>  		*cpu_type = "i386/core_2";
>  		break;
> -	case 26:
> -		*cpu_type = "i386/core_2";
> -		break;
>  	default:
>  		/* Unknown */
>  		return 0;
> -- 
> 1.5.6
> 
> 

-- 
Advanced Micro Devices, Inc.
Operating System Research Center
email: rob...@am...