From: Philippe E. <ph...@wa...> - 2007-04-13 19:06:32
|
On Fri, 13 Apr 2007 at 15:01 +0000, Will Cohen wrote: > It looks like are some other violators of this in the libop/op_cpu_type.h: > CPU_PPC64_POWER5, /**< ppc64 POWER5 family */ > + CPU_PPC64_POWER5p, /**< ppc64 Power5+ family */ > CPU_PPC64_970, /**< ppc64 970 family */ > + CPU_MIPS_20K, /**< MIPS 20K */ > CPU_MIPS_24K, /**< MIPS 24K */ > + CPU_MIPS_25K, /**< MIPS 25K */ > + CPU_MIPS_34K, /**< MIPS 34K */ > + CPU_MIPS_5K, /**< MIPS 5K */ > CPU_MIPS_R10000, /**< MIPS R10000 */ > Looks like there is going to be some imcompatibility between versions if this > being changed to put the new entries at the end of the enum. > > Or do we just want to fix up CPU_FAMILY10 in cvs and leave the other violators > alone? Those are too old to be changed, when fixing family10, add a comment explaining why new cpu must be added at the end. -- Philippe Elie |