Re: [PATCH] ppc64 backtrace support

[John L. <le...@mo...>]

On Thu, Jul 14, 2005 at 12:48:04PM -0400, Brian Rogan wrote:

> Attached please find a patch to support backtracing on ppc64.  Currently,
> support is only implemented for Power5, although it should be easy to adapt
> to Power4, but I don't have the hardware to try.

Not knowing anything about ppc64, my only comment is that your code
isn't in Linux coding style in some places, in particular if statements
look like this:

	if (!something()) {

not the other variations you have.

regards,
john