#73 make fails on RedHat 2.1AS (Pensacola) in 2.4

closed-wont-fix
nobody
None
5
2003-09-14
2002-09-06
Greg Ames
No

I hit a couple of problems trying to compile the
oprofile kernel module on RedHat 2.1 Advanced Server.
It looks like RedHat pulled a few cool kernel features
from 2.5 back into 2.4.9 to create this release, which
confuses module/compat.h.

[gregames@edge17 oprofile-0.3]$ cat /etc/redhat-release
Red Hat Linux Advanced Server release 2.1AS (Pensacola)
[gregames@edge17 oprofile-0.3]$ uname -r
2.4.9-e.3smp

I had errors involving remap_page_range and
pte_offset. I got past both of these by hacking
module/compat.h to use the newer definitions. After
this hack, the make ran OK until it hit the doc/
directory and then died with:

xsltproc xsl/xhtml.xsl oprofile.xml > oprofile.html
warning: failed to load external entity
"/usr/share/sgml/docbook/xsl-stylesheets/xhtml/docbook.xsl"

...but I already have the doc elsewhere so I didn't dig
into that one. Here's my hack to module/compat.h:

[gregames@gandalf oprofile-0.3]$ diff -u
module/compat.h ~/compat.h
--- module/compat.h Fri Jul 12 11:11:03 2002
+++ /home/gregames/compat.h Fri Sep 6 17:06:55
2002
@@ -63,12 +63,14 @@
#endif

/* 2.5.5 change pte_offset */
-#if V_AT_LEAST(2, 5, 5)
+/* #if V_AT_LEAST(2, 5, 5) */
+#if 1
#define pte_offset pte_offset_kernel
#endif

/* 2.5.3 change prototype of remap_page_range */
-#if V_BEFORE(2,5,3)
+/* #if V_BEFORE(2,5,3) */
+#if 0
#define REMAP_PAGE_RANGE(vma, start, page, page_size,
flags) \ remap_page_range((start), (page),
(page_size), (flags))
#else

Thanks,
Greg Ames

Discussion

  • John Levon

    John Levon - 2002-09-07

    Logged In: YES
    user_id=53034

    I'm inclined to leave this unfixed. I'm sick of Red Hat
    playing fast
    and loose.

    If we were to fix this, we'd need to changes to configure.in to
    identify such changes.

    thanks
    john

    p.s. you will have to modify the .xsl files directly to point to
    your docbook xsl installation, but such is only needed when
    building the docs from source in CVS

     
  • John Levon

    John Levon - 2002-11-07
    • summary: make fails on RedHat 2.1AS (Pensacola) --> make fails on RedHat 2.1AS (Pensacola) in 2.4
     
  • Nobody/Anonymous

    Logged In: NO

    If you dont fix the bug, is it possible to put a link on
    your main page or something to this patch?

    Thanks
    Ian Holsman

     
  • John Levon

    John Levon - 2002-11-09

    Logged In: YES
    user_id=53034

    sure, post a patch against faq.php3 or bugs.php3 from
    oprofile-www CVS.

     
  • John Levon

    John Levon - 2003-09-14

    Logged In: YES
    user_id=53034

    Closing as WONTFIX

     
  • John Levon

    John Levon - 2003-09-14
    • status: open --> closed-wont-fix
     

Log in to post a comment.