#248 ocount should ignore duplicate event names in --events option

None
closed
None
5
2014-09-11
2013-07-25
No

Invoking 'ocount' and passing an events list that contains duplicate event names results in redundant data collection. See the example below:


ocount --system-wide -i 5:1 --events PM_1PLUS_PPC_CMPL,PM_CYC,PM_INST_CMPL,PM_1PLUS_PPC_DISP,PM_RUN_INST_CMPL,PM_CYC

ocount: Press Ctl-c or 'kill -SIGINT 27330' to stop counting

Current time (seconds since epoch): 1374756497
Event counts (scaled) for the whole system:
Event Count % time counted
PM_1PLUS_PPC_CMPL 9,286,283 83.09
PM_CYC 70,229,367 91.44
PM_INST_CMPL 20,358,612 85.88
PM_1PLUS_PPC_DISP 11,982,338 60.54
PM_RUN_INST_CMPL 8,737,812 82.36
PM_CYC 78,097,529 79.06


Probably easiest to simply store the events in a set instead of a vector.

Discussion

  • Maynard Johnson

    Maynard Johnson - 2013-09-25
    • Group: -->
     
  • Maynard Johnson

    Maynard Johnson - 2013-09-25
    • assigned_to: Carl Love
     
  • Carl Love

    Carl Love - 2013-11-05

    proposed fix for filtering out duplicate events. Note the patch will not filter out the event if it is specified multiple times with different umasks, user or kernel settings.

     
  • Maynard Johnson

    Maynard Johnson - 2013-11-06
    • status: open --> open-fixed
     
  • Maynard Johnson

    Maynard Johnson - 2013-11-06

    Patch committed. Thanks.

     
  • Maynard Johnson

    Maynard Johnson - 2014-09-11
    • Status: open-fixed --> closed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks