#172 open(..., O_CREAT|...) lacks third argument

closed-fixed
None
5
2009-07-31
2008-11-02
Anonymous
No

OProfile-0.9.4

At line 47 in libutil++/file_manip.cpp there is a
open(destination.c_str(), O_RDWR|O_CREAT) system call.

This is incorrect: when used with O_CREAT, the open() system calls needs a third argument (file permissions creation mode). In other places in the source code this argument is 0644 (rw-r--r--).

This prevents oprofile-0.9.4 from compiling on Ubuntu 8.10 (there's a compile-time check for this).

david.monniaux@free.fr

Discussion

  • Maynard Johnson

    Maynard Johnson - 2008-11-05
    • assigned_to: nobody --> maynardj
     
  • Maynard Johnson

    Maynard Johnson - 2008-11-06

    Fix committed to CVS.

     
  • Maynard Johnson

    Maynard Johnson - 2008-11-06
    • status: open --> open-fixed
     
  • Maynard Johnson

    Maynard Johnson - 2009-07-31
    • status: open-fixed --> closed-fixed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks