#110 opd_parse_kernel_range(NULL) called with --no-vmlinux

closed-fixed
None
7
2003-11-12
2003-11-11
No

oprofiled crashes on startup with --no-vmlinux . It calls
opd_parse_kernel_range(kernel_range), with
kernel_range=0
(RH 9, vmlinux 2.4.22, gcc 3.3.2)
Both CVS version and oprofile-0.7 have same bug.

For oprofile-0.7:
the fix is:
diff -c oprofiled.c.orig oprofiled.c
*** oprofiled.c.orig 2003-11-11 08:43:03.000000000
-0700
--- oprofiled.c 2003-11-11 08:44:19.000000000 -0700
***************
*** 361,367 ****

opd_options(argc, argv);

! opd_parse_kernel_range(kernel_range);
opd_buf_size = opd_read_fs_int("bufsize");
opd_note_buf_size = opd_read_fs_int("notesize");

--- 361,367 ----

opd_options(argc, argv);

! if (!no_vmlinux)
opd_parse_kernel_range(kernel_range);
opd_buf_size = opd_read_fs_int("bufsize");
opd_note_buf_size = opd_read_fs_int("notesize");

Discussion

  • Philippe Elie

    Philippe Elie - 2003-11-11
    • priority: 5 --> 7
    • assigned_to: nobody --> phil_e
    • status: open --> open-fixed
     
  • Philippe Elie

    Philippe Elie - 2003-11-11

    Logged In: YES
    user_id=318973

    ouch, checking for !no_vmlinux was lost during code
    reorganization,
    thanks for the report and the fix, I adapted your patch to CVS.

    regards,
    Phil

     
  • John Levon

    John Levon - 2003-11-12
    • status: open-fixed --> closed-fixed
     
  • John Levon

    John Levon - 2003-11-12

    Logged In: YES
    user_id=53034

    Fixed in 0.7.1

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks