[Openxml4j-devs] PackagingURIHelper.relativizeURI
Status: Beta
Brought to you by:
neodante
From: Nick B. <ope...@ga...> - 2008-04-03 09:26:28
|
Hi All Just a heads-up that I've ended up largely re-writing this function :/ For .xlsx files, you can have a relation from /xl/worksheets/sheet1.xml to /xl/comments1.xml, which excel stores as a relative path of ../comments1.xml . relativizeURI was incorrectly giving just comments1.xml Unfortunately, my french wasn't up to understanding the comments in the method, to figure out how it was supposed to work, so I ended up replacing it with something hopefully quite a bit simpler. All the old tests for PackagingURIHelper now pass (including the one that failed before), and all the new tests I've added pass too. But, it's quite a major change, so do shout if you spot any problems with it, and I'll endevour to add tests for your uses too! For now though, all the relations generated by poi for .xlsx files are being correctly relativized, which is quite promising! Nick |