Menu

#18 ZipPackage.saveImpl does not re-throw the exception.

open
nobody
5
2011-09-01
2011-09-01
misha
No

ZipPackage.saveImpl need to re-throw an exception and not just log it:

} catch (Exception e) {
logger
.error(\"Fail to save: an error occurs while saving the package : \"
+ e.getMessage());
}

to give a caller any indication that something went wrong saving the modified packages. Otherwise the corrupted files are considered by the caller to be successfully modified with no indication that the file is corrupted.

Discussion


Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.