openwebwork-cvs

[jj v. a. <we...@ma...>]

Log Message:
-----------
Made a little more html use CGI::* methods.

Modified Files:
--------------
    webwork-modperl/lib/WeBWorK/ContentGenerator/Instructor:
        Config.pm

Revision Data
-------------
Index: Config.pm
===================================================================
RCS file: /webwork/cvs/system/webwork-modperl/lib/WeBWorK/ContentGenerator/Instructor/Config.pm,v
retrieving revision 1.2
retrieving revision 1.3
diff -Llib/WeBWorK/ContentGenerator/Instructor/Config.pm -Llib/WeBWorK/ContentGenerator/Instructor/Config.pm -u -r1.2 -r1.3
--- lib/WeBWorK/ContentGenerator/Instructor/Config.pm
+++ lib/WeBWorK/ContentGenerator/Instructor/Config.pm
@@ -228,7 +228,7 @@
 sub display_value {
 	my ($self, $val) = @_;
 	return ' ' if not defined($val);
-	my $str = join(',<br>', @{$val});
+	my $str = join(','.CGI::br(), @{$val});
 	$str = '&nbsp;' if $str !~  /\S/;
 	return $str;
 }
@@ -284,7 +284,7 @@
 	my ($self, $val) = @_;
 	$val = [] if not defined($val);
 	my @vals = @$val;
-	return join(',<br>', @vals);
+	return join(CGI::br(), @vals);
 }
 
 # here r->param() returns an array, so we need a custom
@@ -539,17 +539,18 @@
 	my $configTitle = shift @configSectionArray;
 	print CGI::p(CGI::div({-align=>'center'}, CGI::b($configTitle)));
 
-	print '<table border="1">';
+	print CGI::start_table({-border=>"1"});
 	print '<tr>'.CGI::th('What'). CGI::th('Default') .CGI::th('Current');
 	for my $con (@configSectionArray) {
 		my $conobject = $self->objectify($con);
 		print "\n<tr>";
 		print $conobject->what_string;
-		print CGI::td($conobject->display_value(eval('$default_ce->'.inline_var($con->{var}))));
+		print CGI::td({-align=>"center"}, $conobject->display_value(eval('$default_ce->'.inline_var($con->{var}))));
 		print CGI::td($conobject->entry_widget("widget$widget_count", eval('$ce4->'.inline_var($con->{var}))));
+		print '</tr>';
 		$widget_count++;
 	}
-	print "</table>";
+	print CGI::end_table();
 	print CGI::p(CGI::submit(-name=>'make_changes', -value=>'Save Changes'));
 	print CGI::end_form();