[WWcvs] pg: Allow context to override object class used to create formula

[dpvc v. a. <we...@ma...>]

Log Message:
-----------
Allow context to override object class used to create formula objects
(so that things like ImplicitPlane can create instances of themselves
automatically when needed).

This mechanism needs to be enlarged to encompass the other Value
object classes as well (like the Context()->{parser}{...} hash).

The real problem is that the List object probably shouldn't create a
formula returning a list when it is passed formulas, since there
really isn't much need for a formula returning a list to be
autogenerated (you can create one by hand using Formula if needed).

Right now, ALL the Value objects make themselves into Formulas when
one of their entries is a formula.  For example, Point(1,"x") produces
the same thing as Formula("(1,x)"), and List(1,"x") is the same as
Formula("1,x").  This is good for points, but not so good for lists.
And it might sometimes be nice to have a Vector of Formulas, or a
Matrix with Formula entries (rather than Formulas returning Vectors or
Matrices).  But this would require some serious changes internally in
the Value objects, which make assumptions about their values being
constant.  Changing that will be for another day...

Modified Files:
--------------
    pg/lib/Value:
        Context.pm
        Formula.pm

Revision Data
-------------
Index: Formula.pm
===================================================================
RCS file: /webwork/cvs/system/pg/lib/Value/Formula.pm,v
retrieving revision 1.37
retrieving revision 1.38
diff -Llib/Value/Formula.pm -Llib/Value/Formula.pm -u -r1.37 -r1.38
--- lib/Value/Formula.pm
+++ lib/Value/Formula.pm
@@ -35,15 +35,22 @@
 
 #
 #  Call Parser to make the new item, copying important
-#    fields from the tree.
+#    fields from the tree.  The Context can override the
+#    Context()->{value}{Formula} setting to substitue a
+#    different class to call for creating the formula.
 #
 sub new {
-  shift; my $self = $pkg->SUPER::new(@_);
+  shift; my $self = $$Value::context->{value}{Formula}->create(@_);
   foreach my $id ('open','close') {$self->{$id} = $self->{tree}{$id}}
   return $self;
 }
 
 #
+#  Call Parser to creat the formula
+#
+sub create {shift; $pkg->SUPER::new(@_)}
+
+#
 #  Create the new parser with no string
 #    (we'll fill in its tree by hand)
 #
Index: Context.pm
===================================================================
RCS file: /webwork/cvs/system/pg/lib/Value/Context.pm,v
retrieving revision 1.8
retrieving revision 1.9
diff -Llib/Value/Context.pm -Llib/Value/Context.pm -u -r1.8 -r1.9
--- lib/Value/Context.pm
+++ lib/Value/Context.pm
@@ -33,6 +33,9 @@
       arrays => ['data'],
       values => ['flags','pattern','format'],
     },
+    value => {
+      Formula => "Value::Formula"
+    },
   }, $class;
   my %data = (lists=>{},flags=>{},@_);
   $context->{_lists} = new Value::Context::Lists($context,%{$data{lists}});