From: Mike G. v. a. <we...@ma...> - 2009-09-30 14:38:36
|
Log Message: ----------- Corrects bug (uncovered by newer versions of CGI.pm after version 3.29 and before 3.42) which defaulted students to "guests" in the permission popup menu used for editing the student record. It showed up only for student because there default value was 0 -- which can be treated ambiguously -- as opposed to 2 or 10 which is not. Adding the override switch forces the default value generated in the perl code to override other default values for the popupmenu and provides the expected behavior. This should fix the bug where students were mysteriously reassigned as guests and lost their "submit answer" buttons. sites with older versions of CGI.pm will not have observed this problem. Modified Files: -------------- webwork2/lib/WeBWorK/ContentGenerator/Instructor: UserList.pm Revision Data ------------- Index: UserList.pm =================================================================== RCS file: /webwork/cvs/system/webwork2/lib/WeBWorK/ContentGenerator/Instructor/UserList.pm,v retrieving revision 1.93 retrieving revision 1.94 diff -Llib/WeBWorK/ContentGenerator/Instructor/UserList.pm -Llib/WeBWorK/ContentGenerator/Instructor/UserList.pm -u -r1.93 -r1.94 --- lib/WeBWorK/ContentGenerator/Instructor/UserList.pm +++ lib/WeBWorK/ContentGenerator/Instructor/UserList.pm @@ -823,8 +823,6 @@ return "Users sorted by $names{$primary}, then by $names{$secondary}, then by $names{$ternary}."; } - - sub edit_form { my ($self, $onChange, %actionParams) = @_; @@ -1515,6 +1513,7 @@ values => \@values, default => $default, labels => \%labels, + override => 1, # force default to be selected. (corrects bug on newer CGI }); } } |