From: Sam H. <sh...@ma...> - 2005-12-14 00:56:43
|
On Dec 13, 2005, at 16:32, Davide P.Cervone wrote: > On Dec 13, 2005, at 1:23 PM, Sam Hathaway via activitymail wrote: >> give answer is equivalent message regardless of correctness. >> fixes bug #752. > > I'm not sure I think this is the right solution to this. Now the > student can test for equivalence of answer without submitting. I > think of preview mode as not giving any information except how the > expression has been parsed. It should only give information about > how the answer is being interpretted, not anything else about the > answer (in my opinion). Being told that it is the same as the > previous answer is information about the meaning and the value of > the answer, and I don't think that belongs in preview mode. I see your point. That's quite right. > The lines you changed had already fixed bug 752 in the sense that > they did not give the message in preview mode regardless of the > correctness. So this "attack" on the problem is already blocked by > the old version. I was looking at the Parser version but testing the non-Parser version. I backed out of the change to the parser version, and added the "isPreview" check to the non-parser version. Thanks. -sam |