Re: [OpenWeBWorK-devel] identation patch

[Sam H. <sh...@ma...>]

On Oct 20, 2004, at 6:17 PM, Davide P.Cervone wrote:

>> The ones which first caught my attention are at the top:
>>
>> -use constant MY_PROBLEMS => '  My Problems  ';
>> -use constant MAIN_PROBLEMS => '  Main Problems  ';
>> +use constant MY_PROBLEMS => '	 My Problems	';
>> +use constant MAIN_PROBLEMS => '	 Main Problems	';
>
> I noticed issues like this when you added tabs to the FileManager.pm 
> file as well.  It did not follow the conventions that you specified in 
> the indentation policy.  E.g.,
>
>         my $self                         = shift;
>         my $r                                    = $self->r;
>         my $authz                        = $r->authz;
>         my $user                         = $r->param('user');
>
> now was tabs to "align" the equal signs rather than spaces, as the 
> policy seems to suggest.

I've been using the "Entab" feature of my editor, which simply replaces 
runs of spaces with tabs. Then I have to go through and replace tabs 
with spaces for alignment. Looks like I didn't catch those. (Fixing 
now...)
-sam