From: Mike G. v. a. <we...@ma...> - 2008-04-26 23:29:05
|
Log Message: ----------- Changed join("\0",....) to join(\0, ....) since I'm pretty sure that what was desired was a string separated by nulls. If one of the items in the list began with a number eg 14 you would get \014....\0name...\0 etc. I think \0name evaluates properly but I'm pretty sure that \014 does not. Modified Files: -------------- webwork2/lib/WeBWorK: Form.pm webwork2/lib/WeBWorK/ContentGenerator: Problem.pm ProblemSet.pm Revision Data ------------- Index: Form.pm =================================================================== RCS file: /webwork/cvs/system/webwork2/lib/WeBWorK/Form.pm,v retrieving revision 1.7 retrieving revision 1.8 diff -Llib/WeBWorK/Form.pm -Llib/WeBWorK/Form.pm -u -r1.7 -r1.8 --- lib/WeBWorK/Form.pm +++ lib/WeBWorK/Form.pm @@ -174,7 +174,7 @@ my $self = shift; my %varsFormat = (); foreach my $key ($self->param) { - $varsFormat{$key} = join "\0", $self->param($key); + $varsFormat{$key} = join \0, $self->param($key); } return %varsFormat; Index: Problem.pm =================================================================== RCS file: /webwork/cvs/system/webwork2/lib/WeBWorK/ContentGenerator/Problem.pm,v retrieving revision 1.212 retrieving revision 1.213 diff -Llib/WeBWorK/ContentGenerator/Problem.pm -Llib/WeBWorK/ContentGenerator/Problem.pm -u -r1.212 -r1.213 --- lib/WeBWorK/ContentGenerator/Problem.pm +++ lib/WeBWorK/ContentGenerator/Problem.pm @@ -493,7 +493,7 @@ my $publishedClass = ($set->published) ? "Published" : "Unpublished"; my $publishedText = ($set->published) ? "visible to students." : "hidden from students."; - $self->addmessage(CGI::p("This set is " . CGI::font({class=>$publishedClass}, $publishedText))); + $self->addmessage(CGI::span("This set is " . CGI::font({class=>$publishedClass}, $publishedText))); # test for additional problem validity if it's not already invalid } else { Index: ProblemSet.pm =================================================================== RCS file: /webwork/cvs/system/webwork2/lib/WeBWorK/ContentGenerator/ProblemSet.pm,v retrieving revision 1.89 retrieving revision 1.90 diff -Llib/WeBWorK/ContentGenerator/ProblemSet.pm -Llib/WeBWorK/ContentGenerator/ProblemSet.pm -u -r1.89 -r1.90 --- lib/WeBWorK/ContentGenerator/ProblemSet.pm +++ lib/WeBWorK/ContentGenerator/ProblemSet.pm @@ -74,7 +74,7 @@ my $publishedText = ($set->published) ? "visible to students." : "hidden from students."; my $publishedClass = ($set->published) ? "Published" : "Unpublished"; - $self->addmessage(CGI::p("This set is " . CGI::font({class=>$publishedClass}, $publishedText))) if $authz->hasPermissions($userName, "view_unpublished_sets"); + $self->addmessage(CGI::span("This set is " . CGI::font({class=>$publishedClass}, $publishedText))) if $authz->hasPermissions($userName, "view_unpublished_sets"); $self->{userName} = $userName; $self->{user} = $user; |