openvrml-develop

[Openvrml-develop] Never mind...

[WilTech <in...@wi...>]

I guess I won't need help getting the s/w to work with VC++ 4.0.  I just =
bought Version 6.  Cheap!  Only about $36 after rebate for the standard =
version...

Joseph

[Openvrml-develop] Never mind...

[Jeff D. <ig...@po...>]

I figured out why it didn't work properly for field types beyond MFNode:

In the ftn array, which contains the field type names, it goes:
static char *ftn[] = {
  "SFBool",
  "SFColor",
  "SFFloat",
  "SFImage",
  "SFInt32",
  "SFNode",
  "SFRotation",
  "SFString",
  "SFTime",
  "SFVec2f",
  "SFVec3f",
  "MFColor",
  "MFFloat",
  "MFInt32",
  "MFNode"  <--- Note, no comma
  "MFRotation",
  "MFString",
  "MFTime",
  "MFVec2f",
  "MFVec3f",
};

Therefore fieldTypeName(new VrmlMFNode) => "MFNodeMVRotation"

This patch'll fix the list, and let fieldTypeName work for all types.
-jeff

Index: VrmlField.cpp
===================================================================
RCS file: /cvsroot/openvrml/libvrml97/libvrml97core/src/vrml97/VrmlField.cpp,v
retrieving revision 1.7
diff -u -r1.7 VrmlField.cpp
--- VrmlField.cpp       2000/09/10 00:45:48     1.7
+++ VrmlField.cpp       2000/11/21 18:17:34
@@ -86,7 +86,7 @@
   "MFColor",
   "MFFloat",
   "MFInt32",
-  "MFNode"
+  "MFNode",
   "MFRotation",
   "MFString",
   "MFTime",
@@ -99,7 +99,7 @@
 char const * VrmlField::fieldTypeName() const
 {
   int ft = (int) this->fieldType();
-  if (ft > 0 && ft <= (int) VrmlField::MFNODE)
+  if (ft > 0 && ft <= (int) VrmlField::MFVEC3F)
     return ftn[ft-1];
   return "<invalid field type>";
 }

Re: [Openvrml-develop] Never mind...

[Braden M. <br...@en...>]

On Tue, 21 Nov 2000, Jeff Dubrule wrote:

> This patch'll fix the list, and let fieldTypeName work for all types.

Cool. This looks like something I must have botched a while back. Thanks
for finding it before the 0.9.0 release.

In the future, though, please use the patch manager:

  <https://sourceforge.net/patch/?group_id=7151>

We have the facility, and it's convenient to keep a history of
submissions.

-- 
Braden N. McDaniel                              e-mail: br...@en...
<http://endoframe.com>                          Jabber: br...@ja...

Re: [Openvrml-develop] Never mind...

[Braden M. <br...@en...>]

On Tue, 21 Nov 2000, Braden McDaniel wrote:

> On Tue, 21 Nov 2000, Jeff Dubrule wrote:
>
> > This patch'll fix the list, and let fieldTypeName work for all types.
>
> Cool. This looks like something I must have botched a while back. Thanks
> for finding it before the 0.9.0 release.
>
> In the future, though, please use the patch manager:
>
>   <https://sourceforge.net/patch/?group_id=7151>
>
> We have the facility, and it's convenient to keep a history of
> submissions.

I've fixed the problem. I ended up making more substantial changes to the
code:

<http://cvs.sourceforge.net/cgi-bin/cvsweb.cgi/libvrml97/libvrml97core/src/vrml97/VrmlField.cpp.diff?cvsroot=openvrml&r1=text&tr1=1.8&r2=text&tr2=1.9&f=h>

-- 
Braden N. McDaniel                              e-mail: br...@en...
<http://endoframe.com>                          Jabber: br...@ja...