Menu
▾
▴
openvpn-devel
|
From: flichtenheld (C. Review) <ge...@op...> - 2025-08-06 14:29:52
|
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1134?usp=email
to review the following change.
Change subject: buffer: remove unused function buf_write_alloc_prepend
......................................................................
buffer: remove unused function buf_write_alloc_prepend
Change-Id: I71981e39932cafe3fd68b475fdb81a8f20a3a547
Signed-off-by: Frank Lichtenheld <fr...@li...>
---
M src/openvpn/buffer.h
1 file changed, 0 insertions(+), 6 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/34/1134/1
diff --git a/src/openvpn/buffer.h b/src/openvpn/buffer.h
index 8d6bb64..6f15115 100644
--- a/src/openvpn/buffer.h
+++ b/src/openvpn/buffer.h
@@ -644,12 +644,6 @@
}
static inline uint8_t *
-buf_write_alloc_prepend(struct buffer *buf, int size, bool prepend)
-{
- return prepend ? buf_prepend(buf, size) : buf_write_alloc(buf, size);
-}
-
-static inline uint8_t *
buf_read_alloc(struct buffer *buf, int size)
{
uint8_t *ret;
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1134?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I71981e39932cafe3fd68b475fdb81a8f20a3a547
Gerrit-Change-Number: 1134
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <fr...@li...>
Gerrit-Reviewer: plaisthos <arn...@rf...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-Attention: plaisthos <arn...@rf...>
Gerrit-MessageType: newchange
|
|
From: cron2 (C. Review) <ge...@op...> - 2025-08-06 14:42:37
|
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1134?usp=email ) Change subject: buffer: remove unused function buf_write_alloc_prepend ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1134?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I71981e39932cafe3fd68b475fdb81a8f20a3a547 Gerrit-Change-Number: 1134 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld <fr...@li...> Gerrit-Reviewer: cron2 <ge...@gr...> Gerrit-Reviewer: plaisthos <arn...@rf...> Gerrit-CC: openvpn-devel <ope...@li...> Gerrit-Attention: plaisthos <arn...@rf...> Gerrit-Attention: flichtenheld <fr...@li...> Gerrit-Comment-Date: Wed, 06 Aug 2025 14:42:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment |
|
From: Gert D. <ge...@gr...> - 2025-08-06 14:42:54
|
From: Frank Lichtenheld <fr...@li...> Change-Id: I71981e39932cafe3fd68b475fdb81a8f20a3a547 Signed-off-by: Frank Lichtenheld <fr...@li...> Acked-by: Gert Doering <ge...@gr...> --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1134 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering <ge...@gr...> diff --git a/src/openvpn/buffer.h b/src/openvpn/buffer.h index 8d6bb64..6f15115 100644 --- a/src/openvpn/buffer.h +++ b/src/openvpn/buffer.h @@ -644,12 +644,6 @@ } static inline uint8_t * -buf_write_alloc_prepend(struct buffer *buf, int size, bool prepend) -{ - return prepend ? buf_prepend(buf, size) : buf_write_alloc(buf, size); -} - -static inline uint8_t * buf_read_alloc(struct buffer *buf, int size) { uint8_t *ret; |
|
From: Gert D. <ge...@gr...> - 2025-08-06 18:05:55
|
"Remove unused function" is easy to review :-) - out it goes. BB and
"git grep" confirm.
Your patch has been applied to the master branch.
commit 028846f0f73db0e598a8fcdb3d5578bb5920046c
Author: Frank Lichtenheld
Date: Wed Aug 6 16:42:31 2025 +0200
buffer: remove unused function buf_write_alloc_prepend
Signed-off-by: Frank Lichtenheld <fr...@li...>
Acked-by: Gert Doering <ge...@gr...>
Message-Id: <202...@gr...>
URL: https://www.mail-archive.com/ope...@li.../msg32565.html
Signed-off-by: Gert Doering <ge...@gr...>
--
kind regards,
Gert Doering
|
|
From: cron2 (C. Review) <ge...@op...> - 2025-08-06 18:06:06
|
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1134?usp=email ) Change subject: buffer: remove unused function buf_write_alloc_prepend ...................................................................... buffer: remove unused function buf_write_alloc_prepend Change-Id: I71981e39932cafe3fd68b475fdb81a8f20a3a547 Signed-off-by: Frank Lichtenheld <fr...@li...> Acked-by: Gert Doering <ge...@gr...> Message-Id: <202...@gr...> URL: https://www.mail-archive.com/ope...@li.../msg32565.html Signed-off-by: Gert Doering <ge...@gr...> --- M src/openvpn/buffer.h 1 file changed, 0 insertions(+), 6 deletions(-) diff --git a/src/openvpn/buffer.h b/src/openvpn/buffer.h index ae783c6..1405667 100644 --- a/src/openvpn/buffer.h +++ b/src/openvpn/buffer.h @@ -643,12 +643,6 @@ } static inline uint8_t * -buf_write_alloc_prepend(struct buffer *buf, int size, bool prepend) -{ - return prepend ? buf_prepend(buf, size) : buf_write_alloc(buf, size); -} - -static inline uint8_t * buf_read_alloc(struct buffer *buf, int size) { uint8_t *ret; -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1134?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I71981e39932cafe3fd68b475fdb81a8f20a3a547 Gerrit-Change-Number: 1134 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld <fr...@li...> Gerrit-Reviewer: cron2 <ge...@gr...> Gerrit-Reviewer: plaisthos <arn...@rf...> Gerrit-CC: openvpn-devel <ope...@li...> Gerrit-MessageType: merged |
|
From: cron2 (C. Review) <ge...@op...> - 2025-08-06 18:06:06
|
cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1134?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: buffer: remove unused function buf_write_alloc_prepend ...................................................................... buffer: remove unused function buf_write_alloc_prepend Change-Id: I71981e39932cafe3fd68b475fdb81a8f20a3a547 Signed-off-by: Frank Lichtenheld <fr...@li...> Acked-by: Gert Doering <ge...@gr...> Message-Id: <202...@gr...> URL: https://www.mail-archive.com/ope...@li.../msg32565.html Signed-off-by: Gert Doering <ge...@gr...> --- M src/openvpn/buffer.h 1 file changed, 0 insertions(+), 6 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/34/1134/2 diff --git a/src/openvpn/buffer.h b/src/openvpn/buffer.h index ae783c6..1405667 100644 --- a/src/openvpn/buffer.h +++ b/src/openvpn/buffer.h @@ -643,12 +643,6 @@ } static inline uint8_t * -buf_write_alloc_prepend(struct buffer *buf, int size, bool prepend) -{ - return prepend ? buf_prepend(buf, size) : buf_write_alloc(buf, size); -} - -static inline uint8_t * buf_read_alloc(struct buffer *buf, int size) { uint8_t *ret; -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1134?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I71981e39932cafe3fd68b475fdb81a8f20a3a547 Gerrit-Change-Number: 1134 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld <fr...@li...> Gerrit-Reviewer: cron2 <ge...@gr...> Gerrit-Reviewer: plaisthos <arn...@rf...> Gerrit-CC: openvpn-devel <ope...@li...> Gerrit-MessageType: newpatchset |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X