Menu
▾
▴
openvpn-devel
|
From: d12fk (C. Review) <ge...@op...> - 2025-07-03 19:41:44
|
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1077?usp=email
to review the following change.
Change subject: dns: do not run updown scripts with lwipovpn
......................................................................
dns: do not run updown scripts with lwipovpn
Running the script doesn't make sense with the AFUNIX dev node, so we
simply clear any scripts that have been set before.
Change-Id: I7e9a0c668e0950257632452cfd9eeb236f0120f2
Signed-off-by: Heiko Hund <he...@is...>
---
M src/openvpn/options.c
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/77/1077/1
diff --git a/src/openvpn/options.c b/src/openvpn/options.c
index af097f8..0662b49 100644
--- a/src/openvpn/options.c
+++ b/src/openvpn/options.c
@@ -61,6 +61,7 @@
#include "xkey_common.h"
#include "dco.h"
#include "options_util.h"
+#include "tun_afunix.h"
#include <ctype.h>
@@ -3593,6 +3594,13 @@
struct gc_arena gc = gc_new();
struct dns_options *dns = &o->dns_options;
+ if (is_tun_afunix(o->dev_node))
+ {
+ /* Disable running dns-updown script with lwipovpn */
+ dns->updown_flags = DNS_UPDOWN_NO_FLAGS;
+ dns->updown = NULL;
+ }
+
if (dns->servers || dns_updown_user_set(dns) || dns_updown_forced(dns))
{
/* Clean up env from --dhcp-option DNS config */
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1077?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I7e9a0c668e0950257632452cfd9eeb236f0120f2
Gerrit-Change-Number: 1077
Gerrit-PatchSet: 1
Gerrit-Owner: d12fk <he...@op...>
Gerrit-Reviewer: flichtenheld <fr...@li...>
Gerrit-Reviewer: plaisthos <arn...@rf...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-Attention: plaisthos <arn...@rf...>
Gerrit-Attention: flichtenheld <fr...@li...>
Gerrit-MessageType: newchange
|
|
From: plaisthos (C. Review) <ge...@op...> - 2025-07-07 21:13:53
|
Attention is currently required from: d12fk, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1077?usp=email ) Change subject: dns: do not run updown scripts with lwipovpn ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1077?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I7e9a0c668e0950257632452cfd9eeb236f0120f2 Gerrit-Change-Number: 1077 Gerrit-PatchSet: 2 Gerrit-Owner: d12fk <he...@op...> Gerrit-Reviewer: flichtenheld <fr...@li...> Gerrit-Reviewer: plaisthos <arn...@rf...> Gerrit-CC: openvpn-devel <ope...@li...> Gerrit-Attention: flichtenheld <fr...@li...> Gerrit-Attention: d12fk <he...@op...> Gerrit-Comment-Date: Mon, 07 Jul 2025 21:13:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment |
|
From: Gert D. <ge...@gr...> - 2025-07-08 18:52:24
|
From: Heiko Hund <he...@is...> Running the script doesn't make sense with the AFUNIX dev node, so we simply clear any scripts that have been set before. Change-Id: I7e9a0c668e0950257632452cfd9eeb236f0120f2 Signed-off-by: Heiko Hund <he...@is...> Acked-by: Arne Schwabe <arn...@rf...> --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1077 This mail reflects revision 2 of this Change. Acked-by according to Gerrit (reflected above): Arne Schwabe <arn...@rf...> diff --git a/src/openvpn/options.c b/src/openvpn/options.c index af097f8..0662b49 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -61,6 +61,7 @@ #include "xkey_common.h" #include "dco.h" #include "options_util.h" +#include "tun_afunix.h" #include <ctype.h> @@ -3593,6 +3594,13 @@ struct gc_arena gc = gc_new(); struct dns_options *dns = &o->dns_options; + if (is_tun_afunix(o->dev_node)) + { + /* Disable running dns-updown script with lwipovpn */ + dns->updown_flags = DNS_UPDOWN_NO_FLAGS; + dns->updown = NULL; + } + if (dns->servers || dns_updown_user_set(dns) || dns_updown_forced(dns)) { /* Clean up env from --dhcp-option DNS config */ |
|
From: Gert D. <ge...@gr...> - 2025-07-09 07:46:27
|
Lightly tested on a FreeBSD build with lwipovpn, and stared a bit at
the code.
Your patch has been applied to the master branch.
commit 4dc57d923d23bdc73c7c24a9851c9137f2097d8c
Author: Heiko Hund
Date: Tue Jul 8 20:52:04 2025 +0200
dns: do not run updown scripts with lwipovpn
Signed-off-by: Heiko Hund <he...@is...>
Acked-by: Arne Schwabe <arn...@rf...>
Message-Id: <202...@gr...>
URL: https://www.mail-archive.com/ope...@li.../msg32069.html
Signed-off-by: Gert Doering <ge...@gr...>
--
kind regards,
Gert Doering
|
|
From: cron2 (C. Review) <ge...@op...> - 2025-07-09 07:46:49
|
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1077?usp=email ) Change subject: dns: do not run updown scripts with lwipovpn ...................................................................... dns: do not run updown scripts with lwipovpn Running the script doesn't make sense with the AFUNIX dev node, so we simply clear any scripts that have been set before. Change-Id: I7e9a0c668e0950257632452cfd9eeb236f0120f2 Signed-off-by: Heiko Hund <he...@is...> Acked-by: Arne Schwabe <arn...@rf...> Message-Id: <202...@gr...> URL: https://www.mail-archive.com/ope...@li.../msg32069.html Signed-off-by: Gert Doering <ge...@gr...> --- M src/openvpn/options.c 1 file changed, 8 insertions(+), 0 deletions(-) diff --git a/src/openvpn/options.c b/src/openvpn/options.c index af097f8..0662b49 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -61,6 +61,7 @@ #include "xkey_common.h" #include "dco.h" #include "options_util.h" +#include "tun_afunix.h" #include <ctype.h> @@ -3593,6 +3594,13 @@ struct gc_arena gc = gc_new(); struct dns_options *dns = &o->dns_options; + if (is_tun_afunix(o->dev_node)) + { + /* Disable running dns-updown script with lwipovpn */ + dns->updown_flags = DNS_UPDOWN_NO_FLAGS; + dns->updown = NULL; + } + if (dns->servers || dns_updown_user_set(dns) || dns_updown_forced(dns)) { /* Clean up env from --dhcp-option DNS config */ -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1077?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I7e9a0c668e0950257632452cfd9eeb236f0120f2 Gerrit-Change-Number: 1077 Gerrit-PatchSet: 3 Gerrit-Owner: d12fk <he...@op...> Gerrit-Reviewer: flichtenheld <fr...@li...> Gerrit-Reviewer: plaisthos <arn...@rf...> Gerrit-CC: openvpn-devel <ope...@li...> Gerrit-MessageType: merged |
|
From: cron2 (C. Review) <ge...@op...> - 2025-07-09 07:46:48
|
cron2 has uploaded a new patch set (#3) to the change originally created by d12fk. ( http://gerrit.openvpn.net/c/openvpn/+/1077?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by plaisthos Change subject: dns: do not run updown scripts with lwipovpn ...................................................................... dns: do not run updown scripts with lwipovpn Running the script doesn't make sense with the AFUNIX dev node, so we simply clear any scripts that have been set before. Change-Id: I7e9a0c668e0950257632452cfd9eeb236f0120f2 Signed-off-by: Heiko Hund <he...@is...> Acked-by: Arne Schwabe <arn...@rf...> Message-Id: <202...@gr...> URL: https://www.mail-archive.com/ope...@li.../msg32069.html Signed-off-by: Gert Doering <ge...@gr...> --- M src/openvpn/options.c 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/77/1077/3 diff --git a/src/openvpn/options.c b/src/openvpn/options.c index af097f8..0662b49 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -61,6 +61,7 @@ #include "xkey_common.h" #include "dco.h" #include "options_util.h" +#include "tun_afunix.h" #include <ctype.h> @@ -3593,6 +3594,13 @@ struct gc_arena gc = gc_new(); struct dns_options *dns = &o->dns_options; + if (is_tun_afunix(o->dev_node)) + { + /* Disable running dns-updown script with lwipovpn */ + dns->updown_flags = DNS_UPDOWN_NO_FLAGS; + dns->updown = NULL; + } + if (dns->servers || dns_updown_user_set(dns) || dns_updown_forced(dns)) { /* Clean up env from --dhcp-option DNS config */ -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1077?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I7e9a0c668e0950257632452cfd9eeb236f0120f2 Gerrit-Change-Number: 1077 Gerrit-PatchSet: 3 Gerrit-Owner: d12fk <he...@op...> Gerrit-Reviewer: flichtenheld <fr...@li...> Gerrit-Reviewer: plaisthos <arn...@rf...> Gerrit-CC: openvpn-devel <ope...@li...> Gerrit-MessageType: newpatchset |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X