Menu
▾
▴
openvpn-devel
|
From: cron2 (C. Review) <ge...@op...> - 2025-07-28 10:08:35
|
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1118?usp=email
to review the following change.
Change subject: unit_tests/plugins/auth-pam: fix stdint.h related build error on fedora 42
......................................................................
unit_tests/plugins/auth-pam: fix stdint.h related build error on fedora 42
add <stdint.h> to test_search_and_replace.c to fix build error on
fedora 42 / arm64 ("error: uintptr_t undeclared")
Change-Id: I2ab13767b5aa858e024b45be3d161bf6090de763
Signed-off-by: Gert Doering <ge...@gr...>
---
M tests/unit_tests/plugins/auth-pam/test_search_and_replace.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/18/1118/1
diff --git a/tests/unit_tests/plugins/auth-pam/test_search_and_replace.c b/tests/unit_tests/plugins/auth-pam/test_search_and_replace.c
index d40467f..50b241d 100644
--- a/tests/unit_tests/plugins/auth-pam/test_search_and_replace.c
+++ b/tests/unit_tests/plugins/auth-pam/test_search_and_replace.c
@@ -2,6 +2,7 @@
#include <unistd.h>
#include <stdlib.h>
#include <stdarg.h>
+#include <stdint.h>
#include <string.h>
#include <setjmp.h>
#include <cmocka.h>
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1118?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2ab13767b5aa858e024b45be3d161bf6090de763
Gerrit-Change-Number: 1118
Gerrit-PatchSet: 1
Gerrit-Owner: cron2 <ge...@gr...>
Gerrit-Reviewer: flichtenheld <fr...@li...>
Gerrit-Reviewer: plaisthos <arn...@rf...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-Attention: plaisthos <arn...@rf...>
Gerrit-Attention: flichtenheld <fr...@li...>
Gerrit-MessageType: newchange
|
|
From: flichtenheld (C. Review) <ge...@op...> - 2025-07-28 10:38:43
|
Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1118?usp=email ) Change subject: unit_tests/plugins/auth-pam: fix stdint.h related build error on fedora 42 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1118?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I2ab13767b5aa858e024b45be3d161bf6090de763 Gerrit-Change-Number: 1118 Gerrit-PatchSet: 1 Gerrit-Owner: cron2 <ge...@gr...> Gerrit-Reviewer: flichtenheld <fr...@li...> Gerrit-Reviewer: plaisthos <arn...@rf...> Gerrit-CC: openvpn-devel <ope...@li...> Gerrit-Attention: plaisthos <arn...@rf...> Gerrit-Attention: cron2 <ge...@gr...> Gerrit-Comment-Date: Mon, 28 Jul 2025 10:38:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment |
|
From: Gert D. <ge...@gr...> - 2025-07-28 10:42:52
|
add <stdint.h> to test_search_and_replace.c to fix build error on
fedora 42 / arm64 ("error: uintptr_t undeclared")
Change-Id: I2ab13767b5aa858e024b45be3d161bf6090de763
Signed-off-by: Gert Doering <ge...@gr...>
Acked-by: Frank Lichtenheld <fr...@li...>
---
This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1118
This mail reflects revision 1 of this Change.
Acked-by according to Gerrit (reflected above):
Frank Lichtenheld <fr...@li...>
diff --git a/tests/unit_tests/plugins/auth-pam/test_search_and_replace.c b/tests/unit_tests/plugins/auth-pam/test_search_and_replace.c
index d40467f..50b241d 100644
--- a/tests/unit_tests/plugins/auth-pam/test_search_and_replace.c
+++ b/tests/unit_tests/plugins/auth-pam/test_search_and_replace.c
@@ -2,6 +2,7 @@
#include <unistd.h>
#include <stdlib.h>
#include <stdarg.h>
+#include <stdint.h>
#include <string.h>
#include <setjmp.h>
#include <cmocka.h>
|
|
From: Gert D. <ge...@gr...> - 2025-07-28 11:00:23
|
It seems this would also affect feodora-42 on amd64, we just missed on
the "updates that bring in the breaking change" - but now we are prepared ;-)
Patch has been applied to the master branch.
commit 035d47e6d80996a4cde8af1b35f9ba40b676c825
Author: Gert Doering
Date: Mon Jul 28 12:42:29 2025 +0200
unit_tests/plugins/auth-pam: fix stdint.h related build error on fedora 42
Signed-off-by: Gert Doering <ge...@gr...>
Acked-by: Frank Lichtenheld <fr...@li...>
Message-Id: <202...@gr...>
URL: https://www.mail-archive.com/ope...@li.../msg32384.html
Signed-off-by: Gert Doering <ge...@gr...>
--
kind regards,
Gert Doering
|
|
From: Gert D. <ge...@gr...> - 2025-07-29 10:14:15
Attachments:
signature.asc
|
Hi,
(uh, forgot to send this - push has been done yesterday already)
On Mon, Jul 28, 2025 at 01:00:09PM +0200, Gert Doering wrote:
> It seems this would also affect feodora-42 on amd64, we just missed on
> the "updates that bring in the breaking change" - but now we are prepared ;-)
>
> Patch has been applied to the master branch.
>
> commit 035d47e6d80996a4cde8af1b35f9ba40b676c825
> Author: Gert Doering
> Date: Mon Jul 28 12:42:29 2025 +0200
Frank has pointed out that this is the sort of maintenance fixes we
do want in release/2.6 as well, so here we go... tested via GHA and
local fedora42/arm64 VM
commit 5c968a361fba7362306fcd977acdff52ccb4c884 (release/2.6)
Author: Gert Doering <ge...@gr...>
Date: Mon Jul 28 12:42:29 2025 +0200
unit_tests/plugins/auth-pam: fix stdint.h related build error on fedora 42
gert
-
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany ge...@gr...
|
|
From: cron2 (C. Review) <ge...@op...> - 2025-07-28 11:00:39
|
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1118?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+2 by flichtenheld
Change subject: unit_tests/plugins/auth-pam: fix stdint.h related build error on fedora 42
......................................................................
unit_tests/plugins/auth-pam: fix stdint.h related build error on fedora 42
add <stdint.h> to test_search_and_replace.c to fix build error on
fedora 42 / arm64 ("error: uintptr_t undeclared")
Change-Id: I2ab13767b5aa858e024b45be3d161bf6090de763
Signed-off-by: Gert Doering <ge...@gr...>
Acked-by: Frank Lichtenheld <fr...@li...>
Message-Id: <202...@gr...>
URL: https://www.mail-archive.com/ope...@li.../msg32384.html
Signed-off-by: Gert Doering <ge...@gr...>
---
M tests/unit_tests/plugins/auth-pam/test_search_and_replace.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/18/1118/2
diff --git a/tests/unit_tests/plugins/auth-pam/test_search_and_replace.c b/tests/unit_tests/plugins/auth-pam/test_search_and_replace.c
index d40467f..50b241d 100644
--- a/tests/unit_tests/plugins/auth-pam/test_search_and_replace.c
+++ b/tests/unit_tests/plugins/auth-pam/test_search_and_replace.c
@@ -2,6 +2,7 @@
#include <unistd.h>
#include <stdlib.h>
#include <stdarg.h>
+#include <stdint.h>
#include <string.h>
#include <setjmp.h>
#include <cmocka.h>
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1118?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2ab13767b5aa858e024b45be3d161bf6090de763
Gerrit-Change-Number: 1118
Gerrit-PatchSet: 2
Gerrit-Owner: cron2 <ge...@gr...>
Gerrit-Reviewer: flichtenheld <fr...@li...>
Gerrit-Reviewer: plaisthos <arn...@rf...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-MessageType: newpatchset
|
|
From: cron2 (C. Review) <ge...@op...> - 2025-07-28 11:00:45
|
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1118?usp=email ) Change subject: unit_tests/plugins/auth-pam: fix stdint.h related build error on fedora 42 ...................................................................... unit_tests/plugins/auth-pam: fix stdint.h related build error on fedora 42 add <stdint.h> to test_search_and_replace.c to fix build error on fedora 42 / arm64 ("error: uintptr_t undeclared") Change-Id: I2ab13767b5aa858e024b45be3d161bf6090de763 Signed-off-by: Gert Doering <ge...@gr...> Acked-by: Frank Lichtenheld <fr...@li...> Message-Id: <202...@gr...> URL: https://www.mail-archive.com/ope...@li.../msg32384.html Signed-off-by: Gert Doering <ge...@gr...> --- M tests/unit_tests/plugins/auth-pam/test_search_and_replace.c 1 file changed, 1 insertion(+), 0 deletions(-) diff --git a/tests/unit_tests/plugins/auth-pam/test_search_and_replace.c b/tests/unit_tests/plugins/auth-pam/test_search_and_replace.c index d40467f..50b241d 100644 --- a/tests/unit_tests/plugins/auth-pam/test_search_and_replace.c +++ b/tests/unit_tests/plugins/auth-pam/test_search_and_replace.c @@ -2,6 +2,7 @@ #include <unistd.h> #include <stdlib.h> #include <stdarg.h> +#include <stdint.h> #include <string.h> #include <setjmp.h> #include <cmocka.h> -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1118?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I2ab13767b5aa858e024b45be3d161bf6090de763 Gerrit-Change-Number: 1118 Gerrit-PatchSet: 2 Gerrit-Owner: cron2 <ge...@gr...> Gerrit-Reviewer: flichtenheld <fr...@li...> Gerrit-Reviewer: plaisthos <arn...@rf...> Gerrit-CC: openvpn-devel <ope...@li...> Gerrit-MessageType: merged |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X