Menu
▾
▴
openvpn-devel
|
From: cron2 (C. Review) <ge...@op...> - 2025-10-28 18:36:36
|
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1322?usp=email
to review the following change.
Change subject: remove redundant PULL_DEFINED() macro definition
......................................................................
remove redundant PULL_DEFINED() macro definition
this seems to be a leftover of the time when we had conditional
compilation for "--disable-server" or thus. Commit d6a0cf599
removed PUSH_DEFINED() nearby but overlooked this one.
Change-Id: I9118333bb65cd5db0836abefa5d45a729f0142cc
Signed-off-by: Gert Doering <ge...@gr...>
---
M src/openvpn/options.h
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/22/1322/1
diff --git a/src/openvpn/options.h b/src/openvpn/options.h
index 24253af..125e524 100644
--- a/src/openvpn/options.h
+++ b/src/openvpn/options.h
@@ -769,10 +769,6 @@
#define PULL_DEFINED(opt) ((opt)->pull)
-#ifndef PULL_DEFINED
-#define PULL_DEFINED(opt) (false)
-#endif
-
#ifdef _WIN32
#define ROUTE_OPTION_FLAGS(o) ((o)->route_method & ROUTE_METHOD_MASK)
#else
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1322?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I9118333bb65cd5db0836abefa5d45a729f0142cc
Gerrit-Change-Number: 1322
Gerrit-PatchSet: 1
Gerrit-Owner: cron2 <ge...@gr...>
Gerrit-Reviewer: flichtenheld <fr...@li...>
Gerrit-Reviewer: plaisthos <arn...@rf...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-Attention: plaisthos <arn...@rf...>
Gerrit-Attention: flichtenheld <fr...@li...>
|
|
From: flichtenheld (C. Review) <ge...@op...> - 2025-10-28 19:49:56
|
Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change by cron2. ( http://gerrit.openvpn.net/c/openvpn/+/1322?usp=email ) Change subject: remove redundant PULL_DEFINED() macro definition ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1322?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I9118333bb65cd5db0836abefa5d45a729f0142cc Gerrit-Change-Number: 1322 Gerrit-PatchSet: 1 Gerrit-Owner: cron2 <ge...@gr...> Gerrit-Reviewer: flichtenheld <fr...@li...> Gerrit-Reviewer: plaisthos <arn...@rf...> Gerrit-CC: openvpn-devel <ope...@li...> Gerrit-Attention: plaisthos <arn...@rf...> Gerrit-Attention: cron2 <ge...@gr...> Gerrit-Comment-Date: Tue, 28 Oct 2025 19:49:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes |
|
From: Gert D. <ge...@gr...> - 2025-10-28 20:32:32
|
this seems to be a leftover of the time when we had conditional compilation for "--disable-server" or thus. Commit d6a0cf599 removed PUSH_DEFINED() nearby but overlooked this one. Change-Id: I9118333bb65cd5db0836abefa5d45a729f0142cc Signed-off-by: Gert Doering <ge...@gr...> Acked-by: Frank Lichtenheld <fr...@li...> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1322 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1322 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Frank Lichtenheld <fr...@li...> diff --git a/src/openvpn/options.h b/src/openvpn/options.h index 24253af..125e524 100644 --- a/src/openvpn/options.h +++ b/src/openvpn/options.h @@ -769,10 +769,6 @@ #define PULL_DEFINED(opt) ((opt)->pull) -#ifndef PULL_DEFINED -#define PULL_DEFINED(opt) (false) -#endif - #ifdef _WIN32 #define ROUTE_OPTION_FLAGS(o) ((o)->route_method & ROUTE_METHOD_MASK) #else |
|
From: Gert D. <ge...@gr...> - 2025-10-29 07:08:51
|
Trivial enough .-) and BB confirms that I have not overlooked some random
combination of platform and compile time directive.
Patch has been applied to the master branch.
commit e6ae2bc64239dd99a2d2a94e75fdaff45eb78deb
Author: Gert Doering
Date: Tue Oct 28 21:32:10 2025 +0100
remove redundant PULL_DEFINED() macro definition
Signed-off-by: Gert Doering <ge...@gr...>
Acked-by: Frank Lichtenheld <fr...@li...>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1322
Message-Id: <202...@gr...>
URL: https://www.mail-archive.com/ope...@li.../msg33984.html
Signed-off-by: Gert Doering <ge...@gr...>
--
kind regards,
Gert Doering
|
|
From: cron2 (C. Review) <ge...@op...> - 2025-10-29 07:09:17
|
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1322?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+2 by flichtenheld
Change subject: remove redundant PULL_DEFINED() macro definition
......................................................................
remove redundant PULL_DEFINED() macro definition
this seems to be a leftover of the time when we had conditional
compilation for "--disable-server" or thus. Commit d6a0cf599
removed PUSH_DEFINED() nearby but overlooked this one.
Change-Id: I9118333bb65cd5db0836abefa5d45a729f0142cc
Signed-off-by: Gert Doering <ge...@gr...>
Acked-by: Frank Lichtenheld <fr...@li...>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1322
Message-Id: <202...@gr...>
URL: https://www.mail-archive.com/ope...@li.../msg33984.html
Signed-off-by: Gert Doering <ge...@gr...>
---
M src/openvpn/options.h
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/22/1322/2
diff --git a/src/openvpn/options.h b/src/openvpn/options.h
index 24253af..125e524 100644
--- a/src/openvpn/options.h
+++ b/src/openvpn/options.h
@@ -769,10 +769,6 @@
#define PULL_DEFINED(opt) ((opt)->pull)
-#ifndef PULL_DEFINED
-#define PULL_DEFINED(opt) (false)
-#endif
-
#ifdef _WIN32
#define ROUTE_OPTION_FLAGS(o) ((o)->route_method & ROUTE_METHOD_MASK)
#else
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1322?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I9118333bb65cd5db0836abefa5d45a729f0142cc
Gerrit-Change-Number: 1322
Gerrit-PatchSet: 2
Gerrit-Owner: cron2 <ge...@gr...>
Gerrit-Reviewer: flichtenheld <fr...@li...>
Gerrit-Reviewer: plaisthos <arn...@rf...>
Gerrit-CC: openvpn-devel <ope...@li...>
|
|
From: cron2 (C. Review) <ge...@op...> - 2025-10-29 07:09:18
|
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1322?usp=email ) Change subject: remove redundant PULL_DEFINED() macro definition ...................................................................... remove redundant PULL_DEFINED() macro definition this seems to be a leftover of the time when we had conditional compilation for "--disable-server" or thus. Commit d6a0cf599 removed PUSH_DEFINED() nearby but overlooked this one. Change-Id: I9118333bb65cd5db0836abefa5d45a729f0142cc Signed-off-by: Gert Doering <ge...@gr...> Acked-by: Frank Lichtenheld <fr...@li...> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1322 Message-Id: <202...@gr...> URL: https://www.mail-archive.com/ope...@li.../msg33984.html Signed-off-by: Gert Doering <ge...@gr...> --- M src/openvpn/options.h 1 file changed, 0 insertions(+), 4 deletions(-) diff --git a/src/openvpn/options.h b/src/openvpn/options.h index 24253af..125e524 100644 --- a/src/openvpn/options.h +++ b/src/openvpn/options.h @@ -769,10 +769,6 @@ #define PULL_DEFINED(opt) ((opt)->pull) -#ifndef PULL_DEFINED -#define PULL_DEFINED(opt) (false) -#endif - #ifdef _WIN32 #define ROUTE_OPTION_FLAGS(o) ((o)->route_method & ROUTE_METHOD_MASK) #else -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1322?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I9118333bb65cd5db0836abefa5d45a729f0142cc Gerrit-Change-Number: 1322 Gerrit-PatchSet: 2 Gerrit-Owner: cron2 <ge...@gr...> Gerrit-Reviewer: flichtenheld <fr...@li...> Gerrit-Reviewer: plaisthos <arn...@rf...> Gerrit-CC: openvpn-devel <ope...@li...> |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X