Attention is currently required from: cron2, flichtenheld, plaisthos, stipa.
d12fk has posted comments on this change by d12fk. ( http://gerrit.openvpn.net/c/openvpn/+/1308?usp=email )
Change subject: iservice: use interface index with netsh
......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS1:
> This fails the integer checks on a windows build […]
Done
File src/openvpnserv/interactive.c:
http://gerrit.openvpn.net/c/openvpn/+/1308/comment/96f4a51f_2599d222?usp=email :
PS2, Line 2910: free(RemoveListItem(&(*lists)[undo_wins], CmpAny, NULL));
> Since we removed the only invocation of CmpWString, clang complains that […]
Done
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1308?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I329b407693b97dd048bd3788ecad345d6e25dab2
Gerrit-Change-Number: 1308
Gerrit-PatchSet: 3
Gerrit-Owner: d12fk <he...@op...>
Gerrit-Reviewer: cron2 <ge...@gr...>
Gerrit-Reviewer: flichtenheld <fr...@li...>
Gerrit-Reviewer: plaisthos <arn...@rf...>
Gerrit-Reviewer: stipa <lst...@gm...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-Attention: plaisthos <arn...@rf...>
Gerrit-Attention: cron2 <ge...@gr...>
Gerrit-Attention: flichtenheld <fr...@li...>
Gerrit-Attention: stipa <lst...@gm...>
Gerrit-Comment-Date: Thu, 30 Oct 2025 08:17:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <ge...@gr...>
Comment-In-Reply-To: stipa <lst...@gm...>
|
