Menu
▾
▴
openvpn-devel
|
From: flichtenheld (C. Review) <ge...@op...> - 2025-08-05 12:28:38
|
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1130?usp=email
to review the following change.
Change subject: Add clang-format reformat commit to .git-blame-ignore-revs
......................................................................
Add clang-format reformat commit to .git-blame-ignore-revs
Change-Id: I729ee240e107a629ada5fab6b2ed2399e864cbd0
Signed-off-by: Frank Lichtenheld <fr...@li...>
---
M .git-blame-ignore-revs
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/30/1130/1
diff --git a/.git-blame-ignore-revs b/.git-blame-ignore-revs
index 1fafaac..757d9ad 100644
--- a/.git-blame-ignore-revs
+++ b/.git-blame-ignore-revs
@@ -48,3 +48,6 @@
# Reformat for sp_after_comma=add
e51d9a73693ee742b36e19fb1718e5e27167831d
+
+# The Great Reformatting of 2025, switching to clang-format
+3cca3367e6e0ffeccb8e39cb2c739d1dcb086701
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1130?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I729ee240e107a629ada5fab6b2ed2399e864cbd0
Gerrit-Change-Number: 1130
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <fr...@li...>
Gerrit-Reviewer: plaisthos <arn...@rf...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-Attention: plaisthos <arn...@rf...>
Gerrit-MessageType: newchange
|
|
From: flichtenheld (C. Review) <ge...@op...> - 2025-08-05 13:47:04
|
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1130?usp=email
to look at the new patch set (#2).
Change subject: Add clang-format reformat commit to .git-blame-ignore-revs
......................................................................
Add clang-format reformat commit to .git-blame-ignore-revs
Change-Id: I729ee240e107a629ada5fab6b2ed2399e864cbd0
Signed-off-by: Frank Lichtenheld <fr...@li...>
---
M .git-blame-ignore-revs
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/30/1130/2
diff --git a/.git-blame-ignore-revs b/.git-blame-ignore-revs
index 1fafaac..290e4c3 100644
--- a/.git-blame-ignore-revs
+++ b/.git-blame-ignore-revs
@@ -48,3 +48,8 @@
# Reformat for sp_after_comma=add
e51d9a73693ee742b36e19fb1718e5e27167831d
+
+# The Great Reformatting of 2025, switching to clang-format
+3cca3367e6e0ffeccb8e39cb2c739d1dcb086701
+# Switching to ColumnLimit 0 for clang-format
+21f7d6e1ad65b1f7db673bc98764dc7325858e0b
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1130?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I729ee240e107a629ada5fab6b2ed2399e864cbd0
Gerrit-Change-Number: 1130
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <fr...@li...>
Gerrit-Reviewer: plaisthos <arn...@rf...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-Attention: plaisthos <arn...@rf...>
Gerrit-MessageType: newpatchset
|
|
From: cron2 (C. Review) <ge...@op...> - 2025-08-05 15:05:04
|
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1130?usp=email ) Change subject: Add clang-format reformat commit to .git-blame-ignore-revs ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1130?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I729ee240e107a629ada5fab6b2ed2399e864cbd0 Gerrit-Change-Number: 1130 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld <fr...@li...> Gerrit-Reviewer: cron2 <ge...@gr...> Gerrit-Reviewer: plaisthos <arn...@rf...> Gerrit-CC: openvpn-devel <ope...@li...> Gerrit-Attention: plaisthos <arn...@rf...> Gerrit-Attention: flichtenheld <fr...@li...> Gerrit-Comment-Date: Tue, 05 Aug 2025 15:04:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment |
|
From: Gert D. <ge...@gr...> - 2025-08-05 15:05:17
|
From: Frank Lichtenheld <fr...@li...> Change-Id: I729ee240e107a629ada5fab6b2ed2399e864cbd0 Signed-off-by: Frank Lichtenheld <fr...@li...> Acked-by: Gert Doering <ge...@gr...> --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1130 This mail reflects revision 2 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering <ge...@gr...> diff --git a/.git-blame-ignore-revs b/.git-blame-ignore-revs index 1fafaac..290e4c3 100644 --- a/.git-blame-ignore-revs +++ b/.git-blame-ignore-revs @@ -48,3 +48,8 @@ # Reformat for sp_after_comma=add e51d9a73693ee742b36e19fb1718e5e27167831d + +# The Great Reformatting of 2025, switching to clang-format +3cca3367e6e0ffeccb8e39cb2c739d1dcb086701 +# Switching to ColumnLimit 0 for clang-format +21f7d6e1ad65b1f7db673bc98764dc7325858e0b |
|
From: Gert D. <ge...@gr...> - 2025-08-05 15:08:56
|
Not much to test here, except point "git blame" at your favourite piece
of source code, and see the original commits, not the "everything changed
by clang-format" changes :-) - it's actually not *that* bad this time,
compared to the first Great Reformat, but still, quite distracting.
Your patch has been applied to the master branch.
commit 2cc23415889f5d1b1a6d1837332e8c64eeacbb31
Author: Frank Lichtenheld
Date: Tue Aug 5 17:04:57 2025 +0200
Add clang-format reformat commit to .git-blame-ignore-revs
Signed-off-by: Frank Lichtenheld <fr...@li...>
Acked-by: Gert Doering <ge...@gr...>
Message-Id: <202...@gr...>
URL: https://www.mail-archive.com/ope...@li.../msg32528.html
Signed-off-by: Gert Doering <ge...@gr...>
--
kind regards,
Gert Doering
|
|
From: cron2 (C. Review) <ge...@op...> - 2025-08-05 15:08:59
|
cron2 has uploaded a new patch set (#3) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1130?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: Add clang-format reformat commit to .git-blame-ignore-revs ...................................................................... Add clang-format reformat commit to .git-blame-ignore-revs Change-Id: I729ee240e107a629ada5fab6b2ed2399e864cbd0 Signed-off-by: Frank Lichtenheld <fr...@li...> Acked-by: Gert Doering <ge...@gr...> Message-Id: <202...@gr...> URL: https://www.mail-archive.com/ope...@li.../msg32528.html Signed-off-by: Gert Doering <ge...@gr...> --- M .git-blame-ignore-revs 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/30/1130/3 diff --git a/.git-blame-ignore-revs b/.git-blame-ignore-revs index 1fafaac..290e4c3 100644 --- a/.git-blame-ignore-revs +++ b/.git-blame-ignore-revs @@ -48,3 +48,8 @@ # Reformat for sp_after_comma=add e51d9a73693ee742b36e19fb1718e5e27167831d + +# The Great Reformatting of 2025, switching to clang-format +3cca3367e6e0ffeccb8e39cb2c739d1dcb086701 +# Switching to ColumnLimit 0 for clang-format +21f7d6e1ad65b1f7db673bc98764dc7325858e0b -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1130?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I729ee240e107a629ada5fab6b2ed2399e864cbd0 Gerrit-Change-Number: 1130 Gerrit-PatchSet: 3 Gerrit-Owner: flichtenheld <fr...@li...> Gerrit-Reviewer: cron2 <ge...@gr...> Gerrit-Reviewer: plaisthos <arn...@rf...> Gerrit-CC: openvpn-devel <ope...@li...> Gerrit-MessageType: newpatchset |
|
From: cron2 (C. Review) <ge...@op...> - 2025-08-05 15:09:00
|
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1130?usp=email ) Change subject: Add clang-format reformat commit to .git-blame-ignore-revs ...................................................................... Add clang-format reformat commit to .git-blame-ignore-revs Change-Id: I729ee240e107a629ada5fab6b2ed2399e864cbd0 Signed-off-by: Frank Lichtenheld <fr...@li...> Acked-by: Gert Doering <ge...@gr...> Message-Id: <202...@gr...> URL: https://www.mail-archive.com/ope...@li.../msg32528.html Signed-off-by: Gert Doering <ge...@gr...> --- M .git-blame-ignore-revs 1 file changed, 5 insertions(+), 0 deletions(-) diff --git a/.git-blame-ignore-revs b/.git-blame-ignore-revs index 1fafaac..290e4c3 100644 --- a/.git-blame-ignore-revs +++ b/.git-blame-ignore-revs @@ -48,3 +48,8 @@ # Reformat for sp_after_comma=add e51d9a73693ee742b36e19fb1718e5e27167831d + +# The Great Reformatting of 2025, switching to clang-format +3cca3367e6e0ffeccb8e39cb2c739d1dcb086701 +# Switching to ColumnLimit 0 for clang-format +21f7d6e1ad65b1f7db673bc98764dc7325858e0b -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1130?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I729ee240e107a629ada5fab6b2ed2399e864cbd0 Gerrit-Change-Number: 1130 Gerrit-PatchSet: 3 Gerrit-Owner: flichtenheld <fr...@li...> Gerrit-Reviewer: cron2 <ge...@gr...> Gerrit-Reviewer: plaisthos <arn...@rf...> Gerrit-CC: openvpn-devel <ope...@li...> Gerrit-MessageType: merged |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X