Menu
▾
▴
openvpn-devel
|
From: ordex (C. Review) <ge...@op...> - 2025-07-22 20:22:28
|
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1095?usp=email
to review the following change.
Change subject: dco_linux: fix case statement by using proper error value
......................................................................
dco_linux: fix case statement by using proper error value
A M_ERR constant accidentally slipped in as possible
netlink error value.
Substitute it with the actual code matching the following
error message.
Change-Id: I18df6ef659cab9525dd7847b7dd3950fc1895dd5
Signed-off-by: Antonio Quartulli <an...@ma...>
---
M src/openvpn/dco_linux.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/95/1095/1
diff --git a/src/openvpn/dco_linux.c b/src/openvpn/dco_linux.c
index c92c196..58051f5 100644
--- a/src/openvpn/dco_linux.c
+++ b/src/openvpn/dco_linux.c
@@ -143,7 +143,7 @@
msg(M_ERR, "%s: netlink out of memory error", prefix);
break;
- case -M_ERR:
+ case -NLE_AGAIN:
msg(M_WARN, "%s: netlink reports blocking read - aborting wait", prefix);
break;
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1095?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I18df6ef659cab9525dd7847b7dd3950fc1895dd5
Gerrit-Change-Number: 1095
Gerrit-PatchSet: 1
Gerrit-Owner: ordex <an...@ma...>
Gerrit-Reviewer: flichtenheld <fr...@li...>
Gerrit-Reviewer: plaisthos <arn...@rf...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-Attention: plaisthos <arn...@rf...>
Gerrit-Attention: flichtenheld <fr...@li...>
Gerrit-MessageType: newchange
|
|
From: cron2 (C. Review) <ge...@op...> - 2025-07-23 06:19:58
|
Attention is currently required from: flichtenheld, ordex, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1095?usp=email ) Change subject: dco_linux: fix case statement by using proper error value ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1095?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I18df6ef659cab9525dd7847b7dd3950fc1895dd5 Gerrit-Change-Number: 1095 Gerrit-PatchSet: 2 Gerrit-Owner: ordex <an...@ma...> Gerrit-Reviewer: cron2 <ge...@gr...> Gerrit-Reviewer: flichtenheld <fr...@li...> Gerrit-Reviewer: plaisthos <arn...@rf...> Gerrit-CC: openvpn-devel <ope...@li...> Gerrit-Attention: plaisthos <arn...@rf...> Gerrit-Attention: flichtenheld <fr...@li...> Gerrit-Attention: ordex <an...@ma...> Gerrit-Comment-Date: Wed, 23 Jul 2025 06:19:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment |
|
From: Gert D. <ge...@gr...> - 2025-07-23 06:20:20
|
From: Antonio Quartulli <an...@ma...> A M_ERR constant accidentally slipped in as possible netlink error value. Substitute it with the actual code matching the following error message. Change-Id: I18df6ef659cab9525dd7847b7dd3950fc1895dd5 Signed-off-by: Antonio Quartulli <an...@ma...> Acked-by: Gert Doering <ge...@gr...> --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1095 This mail reflects revision 2 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering <ge...@gr...> diff --git a/src/openvpn/dco_linux.c b/src/openvpn/dco_linux.c index c92c196..58051f5 100644 --- a/src/openvpn/dco_linux.c +++ b/src/openvpn/dco_linux.c @@ -143,7 +143,7 @@ msg(M_ERR, "%s: netlink out of memory error", prefix); break; - case -M_ERR: + case -NLE_AGAIN: msg(M_WARN, "%s: netlink reports blocking read - aborting wait", prefix); break; |
|
From: Gert D. <ge...@gr...> - 2025-07-23 08:15:18
|
Stared at the code, makes sense. Test compiled (after the explosion tonight,
you can never test enough :-) ).
Your patch has been applied to the master branch.
commit f1a2a37897a6517c4c321abb7bc343bf495c94e2
Author: Antonio Quartulli
Date: Wed Jul 23 08:20:06 2025 +0200
dco_linux: fix case statement by using proper error value
Signed-off-by: Antonio Quartulli <an...@ma...>
Acked-by: Gert Doering <ge...@gr...>
Message-Id: <202...@gr...>
URL: https://www.mail-archive.com/ope...@li.../msg32269.html
Signed-off-by: Gert Doering <ge...@gr...>
--
kind regards,
Gert Doering
|
|
From: cron2 (C. Review) <ge...@op...> - 2025-07-23 08:15:31
|
cron2 has uploaded a new patch set (#3) to the change originally created by ordex. ( http://gerrit.openvpn.net/c/openvpn/+/1095?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: dco_linux: fix case statement by using proper error value ...................................................................... dco_linux: fix case statement by using proper error value A M_ERR constant accidentally slipped in as possible netlink error value. Substitute it with the actual code matching the following error message. Change-Id: I18df6ef659cab9525dd7847b7dd3950fc1895dd5 Signed-off-by: Antonio Quartulli <an...@ma...> Acked-by: Gert Doering <ge...@gr...> Message-Id: <202...@gr...> URL: https://www.mail-archive.com/ope...@li.../msg32269.html Signed-off-by: Gert Doering <ge...@gr...> --- M src/openvpn/dco_linux.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/95/1095/3 diff --git a/src/openvpn/dco_linux.c b/src/openvpn/dco_linux.c index f04ebfe..0a73882 100644 --- a/src/openvpn/dco_linux.c +++ b/src/openvpn/dco_linux.c @@ -143,7 +143,7 @@ msg(M_ERR, "%s: netlink out of memory error", prefix); break; - case -M_ERR: + case -NLE_AGAIN: msg(M_WARN, "%s: netlink reports blocking read - aborting wait", prefix); break; -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1095?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I18df6ef659cab9525dd7847b7dd3950fc1895dd5 Gerrit-Change-Number: 1095 Gerrit-PatchSet: 3 Gerrit-Owner: ordex <an...@ma...> Gerrit-Reviewer: cron2 <ge...@gr...> Gerrit-Reviewer: flichtenheld <fr...@li...> Gerrit-Reviewer: plaisthos <arn...@rf...> Gerrit-CC: openvpn-devel <ope...@li...> Gerrit-MessageType: newpatchset |
|
From: cron2 (C. Review) <ge...@op...> - 2025-07-23 08:15:32
|
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1095?usp=email ) Change subject: dco_linux: fix case statement by using proper error value ...................................................................... dco_linux: fix case statement by using proper error value A M_ERR constant accidentally slipped in as possible netlink error value. Substitute it with the actual code matching the following error message. Change-Id: I18df6ef659cab9525dd7847b7dd3950fc1895dd5 Signed-off-by: Antonio Quartulli <an...@ma...> Acked-by: Gert Doering <ge...@gr...> Message-Id: <202...@gr...> URL: https://www.mail-archive.com/ope...@li.../msg32269.html Signed-off-by: Gert Doering <ge...@gr...> --- M src/openvpn/dco_linux.c 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/dco_linux.c b/src/openvpn/dco_linux.c index f04ebfe..0a73882 100644 --- a/src/openvpn/dco_linux.c +++ b/src/openvpn/dco_linux.c @@ -143,7 +143,7 @@ msg(M_ERR, "%s: netlink out of memory error", prefix); break; - case -M_ERR: + case -NLE_AGAIN: msg(M_WARN, "%s: netlink reports blocking read - aborting wait", prefix); break; -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1095?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I18df6ef659cab9525dd7847b7dd3950fc1895dd5 Gerrit-Change-Number: 1095 Gerrit-PatchSet: 3 Gerrit-Owner: ordex <an...@ma...> Gerrit-Reviewer: cron2 <ge...@gr...> Gerrit-Reviewer: flichtenheld <fr...@li...> Gerrit-Reviewer: plaisthos <arn...@rf...> Gerrit-CC: openvpn-devel <ope...@li...> Gerrit-MessageType: merged |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X