[Openvpn-devel] [PATCH applied] Re: multi: Fix type handling for hashes, mostly inotify_watchers

[Gert D. <ge...@gr...>]

This code does not really cater to my sensitivities... but having a long
get_random() go into an uint32_t won't work without either some cast, or
adding a new get_random_u32()... which would be a bit overdoing things
as well (that said, looking at get_random()'s signedness, questions 
do arise).

Anyway.  The changes look reasonable.  The hash stuff will not become
any more pretty - if a pointer is stored, but we really compare "integer
keys" (pointer-as-integer, not pointer-to-integer) casts are needed...

Not tested this beyond "BBs are happy", but the inotify stuff will be
excercised by the server side testbed (which will tell me tomorrow if
it *did* break something).

Your patch has been applied to the master branch.

commit e2c97f3833a5616004da4d84fb9e0d023c9033e5
Author: Frank Lichtenheld
Date:   Mon Dec 15 15:55:23 2025 +0100

     multi: Fix type handling for hashes, mostly inotify_watchers

     Signed-off-by: Frank Lichtenheld <fr...@li...>
     Acked-by: Gert Doering <ge...@gr...>
     Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1312
     Message-Id: <202...@gr...>
     URL: https://www.mail-archive.com/ope...@li.../msg35072.html
     Signed-off-by: Gert Doering <ge...@gr...>


--
kind regards,

Gert Doering