[Openvpn-devel] [PATCH applied] Re: Prevent crash on invalid server-ipv6 argument

[Gert D. <ge...@gr...>]

Thanks for your patch.  

Repeating what was said in https://github.com/OpenVPN/openvpn/pull/930,
for the sake of the archives - on FreeBSD and Linux, this does not crash,
because the libraries handle "ai == NULL" gracefully.  The FreeBSD 
implementation mentions that the standard is not clear, so OpenBSD is
free to crash on us.

This said, we do guard all other paths to freeaddrinfo() (either because
the call is only on the "success" branch, or with an explicit check) - so
this is a good fix to make our code consistent.

Your patch has been applied to the master and release/2.6 branch.

commit 0ff66c056f951dcf01cf6ccb3e9b21948e5ca5ad (master)
commit 09c35f8421028ce8aed4895a526c2f4c4b4be01b (release/2.6)
Author: Klemens Nanni
Date:   Sun Dec 7 22:05:18 2025 +0100

     Prevent crash on invalid server-ipv6 argument

     Signed-off-by: Klemens Nanni <kn...@op...>
     Acked-by: Gert Doering <ge...@gr...>
     Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1418
     Message-Id: <202...@gr...>
     URL: https://www.mail-archive.com/ope...@li.../msg34870.html
     Signed-off-by: Gert Doering <ge...@gr...>


--
kind regards,

Gert Doering