[Openvpn-devel] [XS] Change in openvpn[master]: Prevent crash on invalid server-ipv6 argument

[cron2 (C. Review) <ge...@op...>]

Attention is currently required from: klemens, plaisthos.

cron2 has posted comments on this change by klemens. ( http://gerrit.openvpn.net/c/openvpn/+/1418?usp=email )

Change subject: Prevent crash on invalid server-ipv6 argument
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1: 
On FreeBSD and Linux, freeaddrinfo(NULL) seems to be safe, but the comment inside FreeBSD's lib sources hint at "this is not clearly defined in the standard" and it seems OpenBSD prefes to make that point very clear.

We do actually check getaddrinfo() return everywhere else and only do `freeaddrinfo(ai)` in the success branch, or after testing for `not NULL`, so this is a very reasonable change.

(I might add some wording about this to the commit message)



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1418?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I99a6604fdfc682f9609bfe7672aa78285084dcb9
Gerrit-Change-Number: 1418
Gerrit-PatchSet: 1
Gerrit-Owner: klemens <kn...@op...>
Gerrit-Reviewer: cron2 <ge...@gr...>
Gerrit-Reviewer: plaisthos <arn...@rf...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-Attention: plaisthos <arn...@rf...>
Gerrit-Attention: klemens <kn...@op...>
Gerrit-Comment-Date: Sat, 06 Dec 2025 20:57:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No