|
From: ordex (C. Review) <ge...@op...> - 2025-12-04 12:47:35
|
Attention is currently required from: plaisthos. ordex has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1190?usp=email ) Change subject: Clarify some code in epoch with better comments ...................................................................... Patch Set 2: Code-Review-1 (2 comments) File src/openvpn/crypto.h: http://gerrit.openvpn.net/c/openvpn/+/1190/comment/7157deb0_b889163c?usp=email : PS2, Line 312: * limit is reached. */ shouldn't the closing */ be on a new line like all other multiline comments? File src/openvpn/crypto.c: http://gerrit.openvpn.net/c/openvpn/+/1190/comment/ccf561c6_6036bff1?usp=email : PS2, Line 105: * iterate the epoch */ same here -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1190?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I34e6b680618a52003d8408852d415c8aeac01feb Gerrit-Change-Number: 1190 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos <arn...@rf...> Gerrit-Reviewer: flichtenheld <fr...@li...> Gerrit-Reviewer: ordex <an...@ma...> Gerrit-CC: openvpn-devel <ope...@li...> Gerrit-Attention: plaisthos <arn...@rf...> Gerrit-Comment-Date: Thu, 04 Dec 2025 12:47:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes |