[Openvpn-devel] [S] Change in openvpn[master]: win32: ensure plugin dir has the trailing slash

[cron2 (C. Review) <ge...@op...>]

Attention is currently required from: flichtenheld, plaisthos, stipa.

cron2 has posted comments on this change by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1332?usp=email )

Change subject: win32: ensure plugin dir has the trailing slash
......................................................................


Patch Set 2: Code-Review-2

(1 comment)

Patchset:

PS2: 
This is a bit annoying, with the back and forth of `PATHCCH_ENSURE_TRAILING_SLASH` in the iservice, we actually lost the configure.ac block that tests for it again, in commit 763160a16a.  So this can't go in as it is.

So I do wonder if it makes more sense to have a manual check + `strcat()` on `normalized_plugin_dir` instead?  Since this is already normalized via `GetFullPathNameW()`, bringing in the new API just for the last character really is a bit heavy...



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1332?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I5ea90594493ab5cb858f7495f773e080b379e8e8
Gerrit-Change-Number: 1332
Gerrit-PatchSet: 2
Gerrit-Owner: stipa <lst...@gm...>
Gerrit-Reviewer: cron2 <ge...@gr...>
Gerrit-Reviewer: flichtenheld <fr...@li...>
Gerrit-Reviewer: plaisthos <arn...@rf...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-Attention: plaisthos <arn...@rf...>
Gerrit-Attention: flichtenheld <fr...@li...>
Gerrit-Attention: stipa <lst...@gm...>
Gerrit-Comment-Date: Sat, 15 Nov 2025 16:49:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes