[Openvpn-devel] [M] Change in openvpn[master]: tapctl: make output of 'list' and 'create' commands more verbose

[cron2 (C. Review) <ge...@op...>]

Attention is currently required from: plaisthos, stipa.

cron2 has posted comments on this change by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1372?usp=email )

Change subject: tapctl: make output of 'list' and 'create' commands more verbose
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

File src/tapctl/main.c:

http://gerrit.openvpn.net/c/openvpn/+/1372/comment/e8c04fb5_f9261de4?usp=email :
PS1, Line 292:         const WCHAR *name_to_print = final_name ? final_name : L"";
this looks a bit superfluous?  This branch is only entered `if (final_name)`



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1372?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iac6bcf8b5434aa414e86cb4b9742e7dd591dc796
Gerrit-Change-Number: 1372
Gerrit-PatchSet: 1
Gerrit-Owner: stipa <lst...@gm...>
Gerrit-Reviewer: cron2 <ge...@gr...>
Gerrit-Reviewer: plaisthos <arn...@rf...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-Attention: plaisthos <arn...@rf...>
Gerrit-Attention: stipa <lst...@gm...>
Gerrit-Comment-Date: Fri, 14 Nov 2025 21:25:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes