[Openvpn-devel] [S] Change in openvpn[master]: win32: ensure plugin dir has the trailing slash

[cron2 (C. Review) <ge...@op...>]

Attention is currently required from: flichtenheld, plaisthos, stipa.

cron2 has posted comments on this change by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1332?usp=email )

Change subject: win32: ensure plugin dir has the trailing slash
......................................................................


Patch Set 1: Code-Review-2

(1 comment)

Patchset:

PS1: 
this breaks autoconf/automake compilation because the new library is not added to src/openvpn/Makefile.am

```
if WIN32
openvpn_SOURCES += openvpn_win32_resources.rc wfp_block.c wfp_block.h
openvpn_LDADD += -lgdi32 -lws2_32 -lwininet -lcrypt32 -liphlpapi -lwinmm -lfwpuc
lnt -lrpcrt4 -lncrypt -lsetupapi -lbcrypt
endif
```



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1332?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I5ea90594493ab5cb858f7495f773e080b379e8e8
Gerrit-Change-Number: 1332
Gerrit-PatchSet: 1
Gerrit-Owner: stipa <lst...@gm...>
Gerrit-Reviewer: cron2 <ge...@gr...>
Gerrit-Reviewer: flichtenheld <fr...@li...>
Gerrit-Reviewer: plaisthos <arn...@rf...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-Attention: plaisthos <arn...@rf...>
Gerrit-Attention: flichtenheld <fr...@li...>
Gerrit-Attention: stipa <lst...@gm...>
Gerrit-Comment-Date: Thu, 30 Oct 2025 19:32:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes