|
From: plaisthos (C. Review) <ge...@op...> - 2025-10-29 13:44:06
|
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1328?usp=email
to review the following change.
Change subject: Fix warnings about conversion from int to unsigned char/uint8_t
......................................................................
Fix warnings about conversion from int to unsigned char/uint8_t
When compiling with cmake -DCMAKE_BUILD_TYPE=ASAN under Ubuntu 25.10
(gcc 15.2.0).
Explicitly cast these instances to uint8_t/unssigned char to silence this
warning.
Change-Id: I648ee99b1152b1248d1b3e64af7679ab99f1388f
Signed-off-by: Arne Schwabe <ar...@rf...>
---
M src/openvpn/httpdigest.c
M src/openvpn/mroute.c
2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/28/1328/1
diff --git a/src/openvpn/httpdigest.c b/src/openvpn/httpdigest.c
index be20638..3e6520a 100644
--- a/src/openvpn/httpdigest.c
+++ b/src/openvpn/httpdigest.c
@@ -46,7 +46,7 @@
}
else
{
- Hex[i * 2] = (j + 'a' - 10);
+ Hex[i * 2] = (unsigned char)(j + 'a' - 10);
}
j = Bin[i] & 0xf;
if (j <= 9)
@@ -55,7 +55,7 @@
}
else
{
- Hex[i * 2 + 1] = (j + 'a' - 10);
+ Hex[i * 2 + 1] = (unsigned char)(j + 'a' - 10);
}
}
Hex[HASHHEXLEN] = '\0';
diff --git a/src/openvpn/mroute.c b/src/openvpn/mroute.c
index b50d48f..d17902f 100644
--- a/src/openvpn/mroute.c
+++ b/src/openvpn/mroute.c
@@ -337,7 +337,7 @@
}
else
{
- ma->v6.addr.s6_addr[byte--] &= (0xFF << bits_to_clear);
+ ma->v6.addr.s6_addr[byte--] &= (uint8_t)(0xFF << bits_to_clear);
bits_to_clear = 0;
}
}
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1328?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I648ee99b1152b1248d1b3e64af7679ab99f1388f
Gerrit-Change-Number: 1328
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <arn...@rf...>
Gerrit-Reviewer: flichtenheld <fr...@li...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-Attention: flichtenheld <fr...@li...>
|