[Openvpn-devel] [M] Change in openvpn[master]: PUSH_UPDATE server: invalid read bug-fix and unit-tests improvements

[mrbff (C. Review) <ge...@op...>]

Attention is currently required from: flichtenheld, plaisthos.

mrbff has posted comments on this change by mrbff. ( http://gerrit.openvpn.net/c/openvpn/+/1316?usp=email )

Change subject: PUSH_UPDATE server: invalid read bug-fix and unit-tests improvements
......................................................................


Patch Set 4:

(2 comments)

File tests/unit_tests/openvpn/test_push_update_msg.c:

http://gerrit.openvpn.net/c/openvpn/+/1316/comment/56b80860_c9cc6bd8?usp=email :
PS3, Line 140:     i++;
> i seems unused?
yes, you are right, not needed anymore


http://gerrit.openvpn.net/c/openvpn/+/1316/comment/30b59b99_cd44b706?usp=email :
PS3, Line 409: #define expect_control_channel_strings()                             \
> Just give the macro an argument instead of using global res.
Done



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1316?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Idba419681fe3ccc4e6e2f6ce7592332dcff62cd9
Gerrit-Change-Number: 1316
Gerrit-PatchSet: 4
Gerrit-Owner: mrbff <ma...@ma...>
Gerrit-Reviewer: flichtenheld <fr...@li...>
Gerrit-Reviewer: plaisthos <arn...@rf...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-Attention: plaisthos <arn...@rf...>
Gerrit-Attention: flichtenheld <fr...@li...>
Gerrit-Comment-Date: Wed, 29 Oct 2025 13:18:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <fr...@li...>