[Openvpn-devel] [M] Change in openvpn[master]: PUSH_UPDATE server: added new unit tests and improved documentation

[flichtenheld (C. Review) <ge...@op...>]

Attention is currently required from: mrbff, plaisthos.

flichtenheld has posted comments on this change by mrbff. ( http://gerrit.openvpn.net/c/openvpn/+/1316?usp=email )

Change subject: PUSH_UPDATE server: added new unit tests and improved documentation
......................................................................


Patch Set 1: Code-Review-2

(1 comment)

Patchset:

PS1: 
Actually on second thought this whole code should be replaced with "check_expected". This is exactly what it is intended for. See my recent test_options_parse.c for example



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1316?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Idba419681fe3ccc4e6e2f6ce7592332dcff62cd9
Gerrit-Change-Number: 1316
Gerrit-PatchSet: 1
Gerrit-Owner: mrbff <ma...@ma...>
Gerrit-Reviewer: flichtenheld <fr...@li...>
Gerrit-Reviewer: plaisthos <arn...@rf...>
Gerrit-CC: openvpn-devel <ope...@li...>
Gerrit-Attention: plaisthos <arn...@rf...>
Gerrit-Attention: mrbff <ma...@ma...>
Gerrit-Comment-Date: Tue, 28 Oct 2025 10:45:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes